Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatecli(golang): use golang-crossbuild #13584

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Jul 4, 2024

Motivation/summary

7.17 uses https://github.com/elastic/golang-crossbuild

elastic/golang-crossbuild#420 was not merged therefore the packaging pipeline failed.

I added the feature branch in the name of the updatecli pipeline to help with creating a branch staring with feature/ in the upstream, then the buidlkite pipeline should be triggered automatically, see

filter_condition: build.branch == "main" || build.branch =~ /^[0-9]+\.[0-9]+$$/ || build.branch =~ /^feature\//

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

@v1v v1v requested review from a team July 4, 2024 12:52
@v1v v1v self-assigned this Jul 4, 2024
Copy link
Member

@endorama endorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock but I'd like a clarification:

elastic/golang-crossbuild#420 was not merged therefore the packaging pipeline failed.

What's the relation between that go update and the failing build? Is it due to the 1.21.12 specified in .go-version?

@v1v
Copy link
Member Author

v1v commented Jul 4, 2024

Is it due to the 1.21.12 specified in .go-version?

That's correct

@v1v v1v merged commit 384747e into elastic:7.17 Jul 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants