Move the healthcheck handler to the root and include about info. #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the git ref in the response if a request is authenticated. That info is also printed on startup. The git ref and the updated timestamp is generated with `make update` Closes elastic#375
jalvz
commented
Dec 12, 2017
| } else if isAuthorized(r, config.SecretToken) { | ||
| sendStatus(w, r, http.StatusOK, about.About()) | ||
| } else { | ||
| sendStatus(w, r, http.StatusOK, nil) |
There was a problem hiding this comment.
we could also forbid completely non authenticated health-check requests...
|
@jalvz I looked into this a while ago, and most solutions recommend using ldflags, e.g. https://www.atatus.com/blog/golang-auto-build-versioning/ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About info contains the version, git ref and build date(*), and is returned only if a request is authenticated.
About is also printed on startup.
The git ref and the updated timestamp are generated with
make update.Closes #375
(*) @beniwohli asked for the build date. This is not exactly the build date, but the timestamp of when you run
make update. Im not sure how I would get the build date...