do not change version globally, just print it on startup #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elastic#396 introduced a bug where the index name contained invalid characters that were added to the global version.
simitt
pushed a commit
to simitt/apm-server
that referenced
this pull request
Dec 18, 2017
elastic#396 introduced a bug where the index name contained invalid characters that were added to the global version.
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Jan 15, 2018
This reverts commit ff4e866. Revert "do not change version globally, just print it on startup (elastic#404)" This reverts commit 75d69a0.
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #396 I introduced a bug where the index name contained invalid characters
that were added to the global version.