-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to elastic/beats@ef6274d0d1e3 #4249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest beats changes also contain making the template
configurable elastic/beats#21212. This is not yet supported by APM Server. It's probably good enough to just not document and officially support it. We could also ensure to always overwrite the config to legacy
for now.
Thanks for the heads up. I think it's fine to just not document it, and say we don't support it. |
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
Codecov Report
@@ Coverage Diff @@
## master #4249 +/- ##
=======================================
Coverage 80.07% 80.07%
=======================================
Files 158 158
Lines 7958 7958
=======================================
Hits 6372 6372
Misses 1586 1586 |
System tests are failing because of an issue in Kibana, should be fixed by elastic/kibana#78941 in the next snapshot. |
* Update to elastic/beats@ef6274d0d1e3 Brings in elastic/beats#21113 * tests/system: add geo.country_name to approvals elastic/elasticsearch#61523 * Update docs * systemtest: another country_name approval
* Update to elastic/beats@ef6274d0d1e3 Brings in elastic/beats#21113 * tests/system: add geo.country_name to approvals elastic/elasticsearch#61523 * Update docs * systemtest: another country_name approval
Motivation/summary
Brings in elastic/beats#21113
Checklist
- [ ] I have updated CHANGELOG.asciidocI have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
Run apm-server on Linux with monitoring enabled, observe cgroup metrics are published.
Related issues
Part of #4070