Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beater: move event ACKer from publisher to beater #4617

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

axw
Copy link
Member

@axw axw commented Jan 13, 2021

Motivation/summary

In the future we will start and stop multiple publishers.
To avoid blocking the publisher.Stop method unnecessarily
during a config reload, move event ACKing to beater.

How to test these changes

  1. Run APM Server with a shutdown timeout configured
  2. Stop Elasticsearch
  3. Send some events
  4. Shutdown APM Server, check that the shutdown timeout is honoured

Related issues

Preparation for #4376

In the future we will start and stop multiple publishers.
To avoid blocking the publisher.Stop method unnecessarily
during a config reload, move event ACKing to beater.
@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #4617 opened

  • Start Time: 2021-01-13T04:58:35.617+0000

  • Duration: 45 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 4607
Skipped 124
Total 4731

Steps errors 2

Expand to view the steps failures

Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage
Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

@axw axw marked this pull request as ready for review January 13, 2021 05:44
@axw axw requested a review from a team January 13, 2021 05:44
@axw axw merged commit 9b2074f into elastic:master Jan 13, 2021
@axw axw deleted the beater-shutdown-timeout branch January 13, 2021 08:59
axw added a commit to axw/apm-server that referenced this pull request Feb 17, 2021
In the future we will start and stop multiple publishers.
To avoid blocking the publisher.Stop method unnecessarily
during a config reload, move event ACKing to beater.
axw added a commit that referenced this pull request Feb 17, 2021
[7.x] beater: move event ACKer from publisher to beater (#4617)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants