Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add upgrading documentation #6709

Merged
merged 10 commits into from
Dec 7, 2021
Merged

docs: Add upgrading documentation #6709

merged 10 commits into from
Dec 7, 2021

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Nov 24, 2021 •
edited
Loading

@bmorelli25 bmorelli25 added backport-7.16 Automated backport with mergify to the 7.16 branch backport-8.0 Automated backport with mergify labels Nov 24, 2021
@bmorelli25 bmorelli25 self-assigned this Nov 24, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Nov 24, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-07T00:51:10.086+0000

  • Duration: 42 min 57 sec

  • Commit: 4bad167

Test stats 🧪

Test Results
Failed 0
Passed 5586
Skipped 19
Total 5605

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

This was referenced Nov 25, 2021
Merged
Closed
bmorelli25
bmorelli25 commented Nov 30, 2021
View reviewed changes
docs/upgrading-to-integration.asciidoc Outdated Show resolved Hide resolved
docs/upgrading-to-integration.asciidoc Show resolved Hide resolved
docs/upgrading-to-integration.asciidoc Outdated Show resolved Hide resolved
docs/upgrading-to-datastreams.asciidoc Show resolved Hide resolved
docs/upgrading-to-datastreams.asciidoc Show resolved Hide resolved
docs/upgrading-to-datastreams.asciidoc Show resolved Hide resolved
@bmorelli25 bmorelli25 marked this pull request as ready for review November 30, 2021 02:48
@bmorelli25 bmorelli25 requested review from stuartnelson3 and a team November 30, 2021 02:48
stuartnelson3
stuartnelson3 reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some questions, but so far looks good

simitt
simitt reviewed Dec 1, 2021
View reviewed changes
docs/upgrading-to-datastreams.asciidoc Outdated Show resolved Hide resolved
docs/upgrading-to-datastreams.asciidoc Outdated Show resolved Hide resolved
docs/upgrading-to-datastreams.asciidoc Show resolved Hide resolved
docs/upgrading-to-datastreams.asciidoc Show resolved Hide resolved
docs/upgrading-to-integration.asciidoc Show resolved Hide resolved
docs/upgrading-to-integration.asciidoc Outdated Show resolved Hide resolved
docs/upgrading-to-integration.asciidoc Outdated Show resolved Hide resolved
@simitt simitt mentioned this pull request Dec 6, 2021
Closed
8 tasks
@bmorelli25 bmorelli25 requested a review from a team December 7, 2021 00:51
axw
axw approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/upgrading-to-datastreams.asciidoc
Comment on lines +8 to +10
Classic indices are deprecated starting in version 7.16.0.
Users that are not ready to <<upgrade-to-apm-integration>> should
upgrade to data streams in the meantime.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be updating these docs again after 7.16.0 is out, right? Data streams are required in 8.0.0, and the apm-server.data_streams.enabled config mentioned further down has been removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. These will be revised again for 8.0 🙃

@bmorelli25 bmorelli25 merged commit 0d1bf75 into elastic:master Dec 7, 2021
@bmorelli25 bmorelli25 deleted the docs-updating branch December 7, 2021 02:23
mergify bot pushed a commit that referenced this pull request Dec 7, 2021
@bmorelli25
docs: Add upgrading documentation (#6709)
d42c815 
Co-authored-by: stuart nelson <hi@stuartnelson.xyz>
(cherry picked from commit 0d1bf75)
@mergify mergify bot mentioned this pull request Dec 7, 2021
Merged
mergify bot pushed a commit that referenced this pull request Dec 7, 2021
@bmorelli25
docs: Add upgrading documentation (#6709)
ae47f52 
Co-authored-by: stuart nelson <hi@stuartnelson.xyz>
(cherry picked from commit 0d1bf75)
@mergify mergify bot mentioned this pull request Dec 7, 2021
Merged
bmorelli25 added a commit that referenced this pull request Dec 7, 2021
@mergify @bmorelli25
docs: Add upgrading documentation (#6709) (#6821)
acd45dd 
Co-authored-by: stuart nelson <hi@stuartnelson.xyz>
(cherry picked from commit 0d1bf75)

Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
bmorelli25 added a commit that referenced this pull request Dec 7, 2021
@mergify @bmorelli25
docs: Add upgrading documentation (#6709) (#6820)
05877f4 
Co-authored-by: stuart nelson <hi@stuartnelson.xyz>
(cherry picked from commit 0d1bf75)

Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
@simitt
Copy link
Contributor

simitt commented Dec 7, 2021

Great work, thanks!

@bmorelli25 bmorelli25 mentioned this pull request Dec 22, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simitt simitt simitt left review comments

@stuartnelson3 stuartnelson3 stuartnelson3 left review comments

@ruflin ruflin ruflin left review comments

@axw axw axw approved these changes

Assignees

@bmorelli25 bmorelli25

Labels
backport-7.16 Automated backport with mergify to the 7.16 branch backport-8.0 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bmorelli25 @apmmachine @simitt @ruflin @axw @stuartnelson3