-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update opentelemetry-collector modules to v0.56.0 #8765
Conversation
This pull request does not have a backport label. Could you fix it @axw? 🙏
NOTE: |
612fb2d
to
f0ec322
Compare
f0ec322
to
c2a0163
Compare
📚 Go benchmark reportDiff with the
report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat |
3966771
to
ae6c52b
Compare
Mostly just adjusting to API changes, but there are some functional changes related to Jaeger span events. open-telemetry/opentelemetry-collector-contrib#10273 uncovered an issue where we were recording the "event" tag as a label, when we should have been recording it as the "message" field in some circumstances.
ae6c52b
to
bff66c5
Compare
This pull request is now in conflicts. Could you fix it @axw? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I did not conduct any manual testing, but suggest that we ask mobile developers to test against the changes after merging.
Tested with |
Motivation/summary
The first commit bumps the OTel module dependencies, and vendored internal/otel_collector code. The second adjusts apm-server code, the bulk of which is just adjusting to API changes, but there are some functional changes noted below. Finally, system tests are updated to the latest OTel SDK.
open-telemetry/opentelemetry-collector-contrib#10273 uncovered an issue where we were recording the "event" tag as a label, when we should have been recording it as the "message" field in some circumstances.
open-telemetry/opentelemetry-proto#373 removed the deprecated LogRecord.Name field. There is no replacement, hence we no longer record
event.action
.Checklist
- [ ] Update package changelog.yml (only if changes toapmpackage
have been made)- [ ] Documentation has been updatedHow to test these changes
Check that OpenTelemetry Swift 1.3 works with the server.
Related issues
Closes #8576