update index pattern convention #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @lmangani, will check it tomorrow. |
|
@tsg I can take care of this PR. |
|
Fixed recurring pcre-fu glitches |
|
@lmangani Could you squash the commits? |
|
ACK |
|
@lmangani As I saw you merged in master, not sure if there was a misunderstanding. As you have made lots of small commits and some fixes I wanted to ask if you feel comfortable to squash the commits into 1 single commit? |
|
Let me close and re-PR clean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch proposal for testing (missing data to fully validate each index) addressing #36 and minor user req. #38