Fix failing tests #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add virtualenv for running Ansible in a reproducible manner. - Change regex for matching Metricbeat output from the system-cpu metricset The order of the JSON keys in the `metricset` object is different in the output than before (I haven't determined why.) - Update the win_copy dest argument to include the file name and not just the destination directory. - Refactor the Makefile and update the README. - Temporarily disable Filebeat testing on Windows while elastic/beats#6145 is resolved.
[DEPRECATION WARNING]: always_run is deprecated. Use check_mode = no instead.. This feature will be removed in version 2.4. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
The hashicorp/precise32 is `ansible_os_family == Mandrake` and none of the Ansible roles handle Mandrake (they expect Debian).
Python 2.6 on Debian 6 doesn't have a method used by Ansible.
TASK [test-install : Install Debs] *************************************************************************************
fatal: [tester-debian6-64]: FAILED! => {"changed": false, "msg": "Unable to install package: 'module' object has no attribute 'get_architectures'"}
ansible/ansible#31471
Use become instead of sudo.
Fixes:
[DEPRECATION WARNING]: Instead of sudo/sudo_user, use become/become_user and make sure become_method is 'sudo'
(default). This feature will be removed in version 2.6. Deprecation warnings can be disabled by setting
deprecation_warnings=False in ansible.cfg.
|
@andrewkroh Thanks for cleaning this up. I triggered a build after merging: https://beats-ci.elastic.co/job/elastic+beats-tester+master/139/ Lets fix elastic/beats#6145 and readd filebeat to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add virtualenv for running Ansible in a reproducible manner.
Change regex for matching Metricbeat output from the system-cpu metricset
The order of the JSON keys in the
metricsetobject is different in the output than before (I haven't determined why.)Update the win_copy dest argument to include the file name and not just the destination directory.
Refactor the Makefile and update the README.
Temporarily disable Filebeat testing Filebeat panic at startup beats#6145 is resolved.
Fix deprecations (sudo -> become, always_run -> check_mode = no).
Use ubuntu/precise32 instead of hashicorp/precise32. The hashicorp/precise32 is
ansible_os_family == Mandrakeand none of the Ansible roles handle Mandrake (they expect Debian).Add workaround for an Ansible issue on Debian 6. APT module: installing deb fails with Python 2.6 and is always changed if arch=all ansible/ansible#31471