document id must be a string

elastic · Sep 18, 2019 · 232f6db · 232f6db
1 parent 0b9b43c
commit 232f6db
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/filebeat/input/log/harvester.go b/filebeat/input/log/harvester.go
@@ -370,7 +370,7 @@ func (h *Harvester) onMessage(
 			timestamp = ts
 		}
 
-		if id != nil {
+		if id != "" {
 			meta = common.MapStr{
 				"id": id,
 			}

diff --git a/libbeat/reader/readjson/json.go b/libbeat/reader/readjson/json.go
@@ -114,7 +114,7 @@ func createJSONError(message string) common.MapStr {
 // respecting the KeysUnderRoot and OverwriteKeys configuration options.
 // If MessageKey is defined, the Text value from the event always
 // takes precedence.
-func MergeJSONFields(data common.MapStr, jsonFields common.MapStr, text *string, config Config) (interface{}, time.Time) {
+func MergeJSONFields(data common.MapStr, jsonFields common.MapStr, text *string, config Config) (string, time.Time) {
 	// The message key might have been modified by multiline
 	if len(config.MessageKey) > 0 && text != nil {
 		jsonFields[config.MessageKey] = *text
@@ -127,12 +127,14 @@ func MergeJSONFields(data common.MapStr, jsonFields common.MapStr, text *string,
 		data["message"] = *text
 	}
 
-	var id interface{}
+	var id string
 	if key := config.DocumentID; key != "" {
 		if tmp, err := jsonFields.GetValue(key); err == nil {
-			id = tmp
+			if v, ok := tmp.(string); ok {
+				id = v
+				jsonFields.Delete(key)
+			}
 		}
-		jsonFields.Delete(key)
 	}
 
 	if config.KeysUnderRoot {