-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add Central Management blacklisting (#9099)
* Add Central Management blacklisting This change allows to define local blacklist for configurations coming from Central Management. If a configuration block matches the given regular expession, it will be ignored: For example: ``` management: blacklist: output: console metricbeat.modules.module: k.{18}s ```
- Loading branch information
Showing
5 changed files
with
534 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,166 @@ | ||
// Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
// or more contributor license agreements. Licensed under the Elastic License; | ||
// you may not use this file except in compliance with the Elastic License. | ||
|
||
package management | ||
|
||
import ( | ||
"fmt" | ||
"regexp" | ||
"strings" | ||
|
||
"github.com/joeshaw/multierror" | ||
"github.com/pkg/errors" | ||
|
||
"github.com/elastic/beats/libbeat/common" | ||
"github.com/elastic/beats/x-pack/libbeat/management/api" | ||
) | ||
|
||
// ConfigBlacklist takes a ConfigBlocks object and filter it based on the given | ||
// blacklist settings | ||
type ConfigBlacklist struct { | ||
patterns map[string]*regexp.Regexp | ||
} | ||
|
||
// ConfigBlacklistSettings holds a list of fields and regular expressions to blacklist | ||
type ConfigBlacklistSettings struct { | ||
Patterns map[string]string `yaml:",inline"` | ||
} | ||
|
||
// Unpack unpacks nested fields set with dot notation like foo.bar into the proper nesting | ||
// in a nested map/slice structure. | ||
func (f *ConfigBlacklistSettings) Unpack(from interface{}) error { | ||
m, ok := from.(map[string]interface{}) | ||
if !ok { | ||
return fmt.Errorf("wrong type, map is expected") | ||
} | ||
|
||
f.Patterns = map[string]string{} | ||
for k, v := range common.MapStr(m).Flatten() { | ||
f.Patterns[k] = fmt.Sprintf("%s", v) | ||
} | ||
|
||
return nil | ||
} | ||
|
||
// NewConfigBlacklist filters configs from CM according to a given blacklist | ||
func NewConfigBlacklist(cfg ConfigBlacklistSettings) (*ConfigBlacklist, error) { | ||
list := ConfigBlacklist{ | ||
patterns: map[string]*regexp.Regexp{}, | ||
} | ||
|
||
for field, pattern := range cfg.Patterns { | ||
exp, err := regexp.Compile(pattern) | ||
if err != nil { | ||
return nil, errors.Wrap(err, fmt.Sprintf("Given expression is not a valid regexp: %s", pattern)) | ||
} | ||
|
||
list.patterns[field] = exp | ||
} | ||
|
||
return &list, nil | ||
} | ||
|
||
// Filter an error if any of the given config blocks is blacklisted | ||
func (c *ConfigBlacklist) Filter(configBlocks api.ConfigBlocks) error { | ||
var errs multierror.Errors | ||
|
||
for _, configs := range configBlocks { | ||
for _, block := range configs.Blocks { | ||
if c.isBlacklisted(configs.Type, block) { | ||
errs = append(errs, fmt.Errorf("Config for '%s' is blacklisted", configs.Type)) | ||
} | ||
} | ||
} | ||
|
||
return errs.Err() | ||
} | ||
|
||
func (c *ConfigBlacklist) isBlacklisted(blockType string, block *api.ConfigBlock) bool { | ||
cfg, err := block.ConfigWithMeta() | ||
if err != nil { | ||
return false | ||
} | ||
|
||
for field, pattern := range c.patterns { | ||
prefix := blockType | ||
if strings.Contains(field, ".") { | ||
prefix += "." | ||
} | ||
|
||
if strings.HasPrefix(field, prefix) { | ||
// This pattern affects a field on this block type | ||
field = field[len(prefix):] | ||
var segments []string | ||
if len(field) > 0 { | ||
segments = strings.Split(field, ".") | ||
} | ||
if c.isBlacklistedBlock(pattern, segments, cfg.Config) { | ||
return true | ||
} | ||
} | ||
} | ||
|
||
return false | ||
} | ||
|
||
func (c *ConfigBlacklist) isBlacklistedBlock(pattern *regexp.Regexp, segments []string, current *common.Config) bool { | ||
if current.IsDict() { | ||
switch len(segments) { | ||
case 0: | ||
for _, field := range current.GetFields() { | ||
if pattern.MatchString(field) { | ||
return true | ||
} | ||
} | ||
|
||
case 1: | ||
// Check field in the dict | ||
val, err := current.String(segments[0], -1) | ||
if err == nil { | ||
return pattern.MatchString(val) | ||
} | ||
// not a string, traverse | ||
child, _ := current.Child(segments[0], -1) | ||
return child != nil && c.isBlacklistedBlock(pattern, segments[1:], child) | ||
|
||
default: | ||
// traverse the tree | ||
child, _ := current.Child(segments[0], -1) | ||
return child != nil && c.isBlacklistedBlock(pattern, segments[1:], child) | ||
|
||
} | ||
} | ||
|
||
if current.IsArray() { | ||
switch len(segments) { | ||
case 0: | ||
// List of elements, match strings | ||
for count, _ := current.CountField(""); count > 0; count-- { | ||
val, err := current.String("", count-1) | ||
if err == nil && pattern.MatchString(val) { | ||
return true | ||
} | ||
|
||
// not a string, traverse | ||
child, _ := current.Child("", count-1) | ||
if child != nil { | ||
if c.isBlacklistedBlock(pattern, segments, child) { | ||
return true | ||
} | ||
} | ||
} | ||
|
||
default: | ||
// List of elements, explode traversal to all of them | ||
for count, _ := current.CountField(""); count > 0; count-- { | ||
child, _ := current.Child("", count-1) | ||
if child != nil && c.isBlacklistedBlock(pattern, segments, child) { | ||
return true | ||
} | ||
} | ||
} | ||
} | ||
|
||
return false | ||
} |
Oops, something went wrong.