Do not activate memcache by default (#4335) (#4389)

The documentation states that the memcache proto can be disabled by commenting out the list of ports. In practice one had to comment out the entire line. Fix it by not initializing the Ports variable inside the defaultConfig of the memcache proto. No other proto has Ports initialized in the defaultConfig.
elastic · May 26, 2017 · 3a58887 · 3a58887
1 parent 5aa60d7
commit 3a58887
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
@@ -49,6 +49,7 @@ https://github.com/elastic/beats/compare/v6.0.0-alpha1...master[Check the HEAD d
 - Remove unnecessary print statement in schema apis {pull}4355[4355]
 
 *Packetbeat*
+- Enable memcache filtering only if a port is specified in the config file. {issue}4335[4335]
 
 *Winlogbeat*
 

diff --git a/packetbeat/protos/memcache/config.go b/packetbeat/protos/memcache/config.go
@@ -18,7 +18,6 @@ type memcacheConfig struct {
 var (
 	defaultConfig = memcacheConfig{
 		ProtocolCommon: config.ProtocolCommon{
-			Ports:              []int{11211},
 			TransactionTimeout: protos.DefaultTransactionExpiration,
 		},
 		UDPTransactionTimeout: protos.DefaultTransactionExpiration,