Skip to content

Commit

Permalink
Remove verbose debug logs from acker
Browse files Browse the repository at this point in the history
Remove some debug log entries about acked events. Those log entries
turn out to be very verbose and of very little use. They do not carry
any information about the acked events, and we already have metrics
about acked events in the 30s metrics and monitoring HTTP endpoint.
  • Loading branch information
belimawr committed May 22, 2024
1 parent 96f4afc commit 63b421d
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions filebeat/beater/acker.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (
"github.com/elastic/beats/v7/filebeat/input/file"
"github.com/elastic/beats/v7/libbeat/beat"
"github.com/elastic/beats/v7/libbeat/common/acker"
"github.com/elastic/elastic-agent-libs/logp"
)

type statefulLogger interface {
Expand All @@ -35,8 +34,6 @@ type statelessLogger interface {
// eventAcker handles publisher pipeline ACKs and forwards
// them to the registrar or directly to the stateless logger.
func eventACKer(statelessOut statelessLogger, statefulOut statefulLogger) beat.EventListener {
log := logp.NewLogger("acker")

return acker.EventPrivateReporter(func(_ int, data []interface{}) {
stateless := 0
states := make([]file.State, 0, len(data))
Expand All @@ -56,12 +53,10 @@ func eventACKer(statelessOut statelessLogger, statefulOut statefulLogger) beat.E
}

if len(states) > 0 {
log.Debugw("stateful ack", "count", len(states))
statefulOut.Published(states)
}

if stateless > 0 {
log.Debugw("stateless ack", "count", stateless)
statelessOut.Published(stateless)
}
})
Expand Down

0 comments on commit 63b421d

Please sign in to comment.