Skip to content

Commit

Permalink
Avoid mapping issues in kubernetes module
Browse files Browse the repository at this point in the history
This contains 2 changes:

 * Do not report `start_time` when it's empty, as that will throw a
 mapping exception
 * Fix `fields.yml`, as some fields were out of place for `event`
 metricset
  • Loading branch information
Carlos Pérez-Aradros Herce committed Sep 28, 2018
1 parent e7f50bf commit 94ae4dc
Show file tree
Hide file tree
Showing 6 changed files with 33 additions and 19 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ https://github.com/elastic/beats/compare/v6.4.0...master[Check the HEAD diff]
- Add docker diskio stats on Windows. {issue}6815[6815] {pull}8126[8126]
- Fix incorrect type conversion of average response time in Haproxy dashboards {pull}8404[8404]
- Fix dropwizard module parsing of metric names. {issue}8365[8365] {pull}6385[8385]
- Avoid mapping issues in kubernetes module. {pull}8487[8487]

*Packetbeat*

Expand Down
7 changes: 5 additions & 2 deletions metricbeat/module/kubernetes/container/data.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ func eventMapping(content []byte, perfMetrics *util.PerfMetricsCache) ([]common.
},
},

"name": container.Name,
"start_time": container.StartTime,
"name": container.Name,

"cpu": common.MapStr{
"usage": common.MapStr{
Expand Down Expand Up @@ -114,6 +113,10 @@ func eventMapping(content []byte, perfMetrics *util.PerfMetricsCache) ([]common.
},
}

if container.StartTime != "" {
containerEvent.Put("start_time", container.StartTime)
}

if nodeCores > 0 {
containerEvent.Put("cpu.usage.node.pct", float64(container.CPU.UsageNanoCores)/1e9/nodeCores)
}
Expand Down
21 changes: 10 additions & 11 deletions metricbeat/module/kubernetes/event/_meta/fields.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,17 @@
type: long
description: >
Count field records the number of times the particular event has occurred
- name: timestamp
type: group
fields:
- name: timestamp
type: group
fields:
- name: first_occurrence
type: date
description: >
Timestamp of first occurrence of event
- name: last_occurrence
type: date
description: >
Timestamp of last occurrence of event
- name: first_occurrence
type: date
description: >
Timestamp of first occurrence of event
- name: last_occurrence
type: date
description: >
Timestamp of last occurrence of event
- name: message
type: keyword
description: >
Expand Down
8 changes: 6 additions & 2 deletions metricbeat/module/kubernetes/node/data.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ func eventMapping(content []byte) (common.MapStr, error) {

node := summary.Node
nodeEvent := common.MapStr{
"name": node.NodeName,
"start_time": node.StartTime,
"name": node.NodeName,

"cpu": common.MapStr{
"usage": common.MapStr{
Expand Down Expand Up @@ -105,5 +104,10 @@ func eventMapping(content []byte) (common.MapStr, error) {
},
},
}

if node.StartTime != "" {
nodeEvent.Put("start_time", node.StartTime)
}

return nodeEvent, nil
}
7 changes: 5 additions & 2 deletions metricbeat/module/kubernetes/pod/data.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@ func eventMapping(content []byte, perfMetrics *util.PerfMetricsCache) ([]common.
"name": node.NodeName,
},
},
"name": pod.PodRef.Name,
"start_time": pod.StartTime,
"name": pod.PodRef.Name,

"cpu": common.MapStr{
"usage": common.MapStr{
Expand All @@ -85,6 +84,10 @@ func eventMapping(content []byte, perfMetrics *util.PerfMetricsCache) ([]common.
},
}

if pod.StartTime != "" {
podEvent.Put("start_time", pod.StartTime)
}

if coresLimit > nodeCores {
coresLimit = nodeCores
}
Expand Down
8 changes: 6 additions & 2 deletions metricbeat/module/kubernetes/system/data.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ func eventMapping(content []byte) ([]common.MapStr, error) {
"name": node.NodeName,
},
},
"container": syscontainer.Name,
"start_time": syscontainer.StartTime,
"container": syscontainer.Name,
"cpu": common.MapStr{
"usage": common.MapStr{
"nanocores": syscontainer.CPU.UsageNanoCores,
Expand All @@ -68,6 +67,11 @@ func eventMapping(content []byte) ([]common.MapStr, error) {
"majorpagefaults": syscontainer.Memory.MajorPageFaults,
},
}

if syscontainer.StartTime != "" {
containerEvent.Put("start_time", syscontainer.StartTime)
}

events = append(events, containerEvent)
}

Expand Down

0 comments on commit 94ae4dc

Please sign in to comment.