-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow delete and index actions with a document ID (#12606)
* Add `op_type` meta key for delete and index operations with a document ID. * Add note on why `obj` can be nil. * Refactor and extract consts. * Don't include metadata prefix in key. * Stop appending `nil` else it ends up in the body. * Error when trying to delete with no _id. * Remove incorrect detail in comment. * Add unit test for new op_type meta key. * No longer required. * Return error to caller. * Fail event if op_type is no string. * Use consts in error. * Replace assert with require. * Fail instead of panic. * Change missed assert calls to require. * Simplify GetMetaStringValue. * Ignore err as key may not exist.
- Loading branch information
1 parent
fed44d5
commit a141e88
Showing
4 changed files
with
105 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters