[GCP] Log ListTimeSeries and AggregatedList requests duration (#4…

…0661) * log total time taken for ListTimeSeries requests * add changelog entry * fix PR id * log total time taken for AggregatedList request * update changelog entry * remove log * Update x-pack/metricbeat/module/gcp/metrics/compute/metadata.go Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update x-pack/metricbeat/module/gcp/metrics/metrics_requester.go Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> * Update x-pack/metricbeat/module/gcp/metrics/compute/metadata.go Co-authored-by: Harnish Chavda <118714680+harnish-elastic@users.noreply.github.com> * Update x-pack/metricbeat/module/gcp/metrics/metrics_requester.go Co-authored-by: Harnish Chavda <118714680+harnish-elastic@users.noreply.github.com> --------- Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com> Co-authored-by: Harnish Chavda <118714680+harnish-elastic@users.noreply.github.com> (cherry picked from commit 3f3e57d)
elastic · Sep 16, 2024 · db4e051 · db4e051
1 parent 29ccd48
commit db4e051
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/CHANGELOG.next.asciidoc b/CHANGELOG.next.asciidoc
@@ -217,6 +217,7 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff]
 - Add metrics related to alert in all the vSphere metricsets. {pull}40714[40714]
 - Add support for period based intervalID in vSphere host and datastore metricsets {pull}40678[40678]
 - Add new metrics for datastore and minor changes to overall vSphere metrics {pull}40766[40766]
+- Log the total time taken for GCP `ListTimeSeries` and `AggregatedList` requests {pull}40661[40661]
 
 *Metricbeat*
 

diff --git a/x-pack/metricbeat/module/gcp/metrics/compute/metadata.go b/x-pack/metricbeat/module/gcp/metrics/compute/metadata.go
@@ -10,6 +10,7 @@ import (
 	"fmt"
 	"strconv"
 	"strings"
+	"time"
 
 	compute "cloud.google.com/go/compute/apiv1"
 	"cloud.google.com/go/compute/apiv1/computepb"
@@ -188,6 +189,11 @@ func (s *metadataCollector) getComputeInstances(ctx context.Context) {
 
 	defer instancesClient.Close()
 
+	start := time.Now()
+	defer func() {
+		s.logger.Debugf("Total time taken for compute AggregatedList request: %s", time.Since(start))
+	}()
+
 	it := instancesClient.AggregatedList(ctx, &computepb.AggregatedListInstancesRequest{
 		Project: s.projectID,
 	})

diff --git a/x-pack/metricbeat/module/gcp/metrics/metrics_requester.go b/x-pack/metricbeat/module/gcp/metrics/metrics_requester.go
@@ -124,6 +124,11 @@ func (r *metricsRequester) Metrics(ctx context.Context, serviceName string, alig
 		}
 	}
 
+	start := time.Now()
+	defer func() {
+		r.logger.Debugf("Total time taken for all ListTimeSeries requests: %s and config period: %s", time.Since(start), r.config.period.AsDuration())
+	}()
+
 	for mt, meta := range metricsToCollect {
 		wg.Add(1)