Adding code to OOTB support AWS Eventbridge generated events for S3 c…

…hanges, see https://docs.aws.amazon.com/AmazonS3/latest/userguide/EventBridge.html
elastic · Jun 25, 2024 · e82a2ca · e82a2ca
1 parent a4f82b1
commit e82a2ca
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/metricbeat/include/list_init.go b/metricbeat/include/list_init.go
diff --git a/x-pack/filebeat/input/awss3/sqs_s3_event.go b/x-pack/filebeat/input/awss3/sqs_s3_event.go
@@ -44,7 +44,7 @@ func (e *nonRetryableError) Error() string {
 }
 
 func (e *nonRetryableError) Is(err error) bool {
-	_, ok := err.(*nonRetryableError) //nolint:errorlint // This is not used directly to detected wrapped errors (errors.Is handles unwrapping).
+	_, ok := err.(*nonRetryableError) // This is not used directly to detected wrapped errors (errors.Is handles unwrapping).
 	return ok
 }
 
@@ -309,8 +309,8 @@ func (p *sqsS3EventProcessor) getS3Notifications(body string) ([]s3EventV2, erro
 }
 
 func convertEventBridge(eventBridgeEvents *eventBridgeEvents, s3Events *s3EventsV2) {
-	for _, message := range eventBridgeEvents.Messages {
-		s3Events.Records = append(s3Events.Records, convertEventBridgeEvent(&message))
+	for i := range eventBridgeEvents.Messages {
+		s3Events.Records = append(s3Events.Records, convertEventBridgeEvent(&eventBridgeEvents.Messages[i]))
 	}
 }
 
@@ -326,7 +326,6 @@ func convertEventBridgeEvent(message *eventBridgeEvent) s3EventV2 {
 	}
 	event.SetS3BucketName(message.Detail.Bucket.Name)
 	event.SetS3ObjectKey(message.Detail.Object.Key)
-	event.SetProvider("aws:s3") //TODO
 	return event
 }
 

diff --git a/x-pack/filebeat/input/awss3/sqs_test.go b/x-pack/filebeat/input/awss3/sqs_test.go
@@ -13,6 +13,8 @@ import (
 	"testing"
 	"time"
 
+	"github.com/aws/aws-sdk-go/service/sqs"
+
 	"github.com/aws/aws-sdk-go-v2/aws"
 	"github.com/aws/aws-sdk-go-v2/service/sqs/types"
 	"github.com/gofrs/uuid"