Make all metricsets in Kafka module defaults. (#6759)

elastic · Apr 4, 2018 · f99660e · f99660e
1 parent b5dc679
commit f99660e
Show file tree

Hide file tree

Showing 8 changed files with 37 additions and 76 deletions.
diff --git a/metricbeat/docs/modules/kafka.asciidoc b/metricbeat/docs/modules/kafka.asciidoc
@@ -9,6 +9,7 @@ beta[]
 
 This is the Kafka module.
 
+The default metricsets are `consumergroup` and `partition`.
 
 
 [float]
@@ -21,30 +22,7 @@ in <<configuration-metricbeat>>. Here is an example configuration:
 ----
 metricbeat.modules:
 - module: kafka
-  metricsets: ["partition"]
-  period: 10s
   hosts: ["localhost:9092"]
-
-  #client_id: metricbeat
-  #retries: 3
-  #backoff: 250ms
-
-  # List of Topics to query metadata for. If empty, all topics will be queried.
-  #topics: []
-
-  # Optional SSL. By default is off.
-  # List of root certificates for HTTPS server verifications
-  #ssl.certificate_authorities: ["/etc/pki/root/ca.pem"]
-
-  # Certificate for SSL client authentication
-  #ssl.certificate: "/etc/pki/client/cert.pem"
-
-  # Client Certificate Key
-  #ssl.key: "/etc/pki/client/cert.key"
-
-  # SASL authentication
-  #username: ""
-  #password: ""
 ----
 
 [float]

diff --git a/metricbeat/metricbeat.reference.yml b/metricbeat/metricbeat.reference.yml
@@ -283,9 +283,10 @@ metricbeat.modules:
 
 #-------------------------------- Kafka Module -------------------------------
 - module: kafka
-  metricsets: ["partition"]
+  metricsets: ["consumergroup", "partition"]
   period: 10s
   hosts: ["localhost:9092"]
+  enabled: true
 
   #client_id: metricbeat
   #retries: 3

diff --git a/metricbeat/module/kafka/_meta/config.reference.yml b/metricbeat/module/kafka/_meta/config.reference.yml
@@ -0,0 +1,26 @@
+- module: kafka
+  metricsets: ["consumergroup", "partition"]
+  period: 10s
+  hosts: ["localhost:9092"]
+  enabled: true
+
+  #client_id: metricbeat
+  #retries: 3
+  #backoff: 250ms
+
+  # List of Topics to query metadata for. If empty, all topics will be queried.
+  #topics: []
+
+  # Optional SSL. By default is off.
+  # List of root certificates for HTTPS server verifications
+  #ssl.certificate_authorities: ["/etc/pki/root/ca.pem"]
+
+  # Certificate for SSL client authentication
+  #ssl.certificate: "/etc/pki/client/cert.pem"
+
+  # Client Certificate Key
+  #ssl.key: "/etc/pki/client/cert.key"
+
+  # SASL authentication
+  #username: ""
+  #password: ""
diff --git a/metricbeat/module/kafka/_meta/config.yml b/metricbeat/module/kafka/_meta/config.yml
@@ -1,25 +1,2 @@
 - module: kafka
-  metricsets: ["partition"]
-  period: 10s
   hosts: ["localhost:9092"]
-
-  #client_id: metricbeat
-  #retries: 3
-  #backoff: 250ms
-
-  # List of Topics to query metadata for. If empty, all topics will be queried.
-  #topics: []
-
-  # Optional SSL. By default is off.
-  # List of root certificates for HTTPS server verifications
-  #ssl.certificate_authorities: ["/etc/pki/root/ca.pem"]
-
-  # Certificate for SSL client authentication
-  #ssl.certificate: "/etc/pki/client/cert.pem"
-
-  # Client Certificate Key
-  #ssl.key: "/etc/pki/client/cert.key"
-
-  # SASL authentication
-  #username: ""
-  #password: ""
diff --git a/metricbeat/module/kafka/_meta/docs.asciidoc b/metricbeat/module/kafka/_meta/docs.asciidoc
@@ -1,2 +1,3 @@
 This is the Kafka module.
 
+The default metricsets are `consumergroup` and `partition`.
diff --git a/metricbeat/module/kafka/consumergroup/consumergroup.go b/metricbeat/module/kafka/consumergroup/consumergroup.go
@@ -13,9 +13,9 @@ import (
 
 // init registers the MetricSet with the central registry.
 func init() {
-	if err := mb.Registry.AddMetricSet("kafka", "consumergroup", New); err != nil {
-		panic(err)
-	}
+	mb.Registry.MustAddMetricSet("kafka", "consumergroup", New,
+		mb.DefaultMetricSet(),
+	)
 }
 
 // MetricSet type defines all fields of the MetricSet

diff --git a/metricbeat/module/kafka/partition/partition.go b/metricbeat/module/kafka/partition/partition.go
@@ -17,9 +17,10 @@ import (
 
 // init registers the partition MetricSet with the central registry.
 func init() {
-	if err := mb.Registry.AddMetricSet("kafka", "partition", New, parse.PassThruHostParser); err != nil {
-		panic(err)
-	}
+	mb.Registry.MustAddMetricSet("kafka", "partition", New,
+		mb.WithHostParser(parse.PassThruHostParser),
+		mb.DefaultMetricSet(),
+	)
 }
 
 // MetricSet type defines all fields of the partition MetricSet

diff --git a/metricbeat/modules.d/kafka.yml.disabled b/metricbeat/modules.d/kafka.yml.disabled
@@ -1,25 +1,2 @@
 - module: kafka
-  metricsets: ["partition"]
-  period: 10s
   hosts: ["localhost:9092"]
-
-  #client_id: metricbeat
-  #retries: 3
-  #backoff: 250ms
-
-  # List of Topics to query metadata for. If empty, all topics will be queried.
-  #topics: []
-
-  # Optional SSL. By default is off.
-  # List of root certificates for HTTPS server verifications
-  #ssl.certificate_authorities: ["/etc/pki/root/ca.pem"]
-
-  # Certificate for SSL client authentication
-  #ssl.certificate: "/etc/pki/client/cert.pem"
-
-  # Client Certificate Key
-  #ssl.key: "/etc/pki/client/cert.key"
-
-  # SASL authentication
-  #username: ""
-  #password: ""
Original file line number	Diff line number	Diff line change
		@@ -1,2 +1,3 @@
		This is the Kafka module.

		The default metricsets are `consumergroup` and `partition`.