Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a readme to test the KVM module #10217

Closed
alvarolobato opened this issue Jan 21, 2019 · 7 comments
Closed

Create a readme to test the KVM module #10217

alvarolobato opened this issue Jan 21, 2019 · 7 comments
Labels
candidate Candidate to be added to the current iteration Metricbeat Metricbeat module Stalled Team:Integrations Label for the Integrations team

Comments

@alvarolobato
Copy link

Should contain instructions on how to setup the environment.

@alvarolobato alvarolobato added the Team:Integrations Label for the Integrations team label Jan 21, 2019
@ruflin
Copy link
Contributor

ruflin commented Jan 23, 2019

@jsoriano As part of writing this readme and setting up KVM, could you also update the data.json file? https://github.com/elastic/beats/blob/master/metricbeat/module/kvm/dommemstat/_meta/data.json

@ruflin
Copy link
Contributor

ruflin commented Jan 23, 2019

@amandahla If you find some time to update the data.json that would also be great.

ruflin added a commit to ruflin/beats that referenced this issue Jan 24, 2019
A follow up issue can be found here elastic#10217 to create docs on how to test this.
ruflin added a commit that referenced this issue Jan 24, 2019
A follow up issue can be found here #10217 to create docs on how to test this.
@amandahla
Copy link

Hi @ruflin , do you want me to open a PR for this? The updated file is here

@amandahla
Copy link

Hi @alvarolobato , I'm not sure if this is what you want for the README file but I followed these instructions to create a minimum KVM environment to build this module.

Then in the metricbeat.yml:

- module: kvm
  metricsets: ["dommemstat"]
  enabled: true
  period: 5s
  hosts: ["unix:///var/run/libvirt/libvirt-sock"]

@ruflin
Copy link
Contributor

ruflin commented Jan 25, 2019

@amandahla Would be great if you could open a PR with the updated data.json.

@jsoriano In case you need in some inspiration for the Readme: https://www.howtogeek.com/117635/how-to-install-kvm-and-create-virtual-machines-on-ubuntu/

@amandahla The goal on our end is to make this module GA but for this to happen, we must have a reliable and reproducible way to setup an environment on our end to debug potential support issues. In most modules we have a Dockerfile for this but this is not really feasible for kvm.

@jsoriano
Copy link
Member

I started to try to script some test with our test framework using docker, this test will need linux and kvm for good, but maybe we can make libvirtd work also with software emulation if kvm is not available.
My main problem now is to create a minimal base image.
I will try to continue next week.

@andresrc andresrc added candidate Candidate to be added to the current iteration [zube]: Ready and removed [zube]: Backlog labels Nov 12, 2019
@jsoriano jsoriano removed their assignment Nov 25, 2021
@botelastic
Copy link

botelastic bot commented Nov 25, 2022

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Nov 25, 2022
@botelastic botelastic bot closed this as completed May 24, 2023
@zube zube bot added [zube]: Done and removed [zube]: Ready labels May 24, 2023
@zube zube bot removed the [zube]: Done label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate Candidate to be added to the current iteration Metricbeat Metricbeat module Stalled Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

5 participants