Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloud metadata processor docs are out of date #10775

Closed
andrewvc opened this issue Feb 15, 2019 · 4 comments
Closed

Add cloud metadata processor docs are out of date #10775

andrewvc opened this issue Feb 15, 2019 · 4 comments
Labels
docs ecs :Infra Stalled Team:Integrations Label for the Integrations team v7.0.0

Comments

@andrewvc
Copy link
Contributor

This came up in a discussion with @ruflin who was on his way out and asked me to open an issue. Apparently the docs for https://www.elastic.co/guide/en/beats/filebeat/master/add-cloud-metadata.html are out of date with the latest implementation and should be updated.
@andrewvc andrewvc added docs :Infra Team:Integrations Label for the Integrations team labels Feb 15, 2019
@andrewkroh
Copy link
Member

I added a fix in #10987.

@andrewkroh andrewkroh mentioned this issue Feb 28, 2019
Merged
andrewkroh added a commit that referenced this issue Mar 1, 2019
@andrewkroh
Trim project from GCE cloud metadata (#10987)
f527cd5 
This removes the project info from the cloud.machine.type and cloud.availability_zone fields
that are added to the add_cloud_metadata processor for Google Compute Engine (GCE).

Fixes #10968, #10775 (docs)
@andrewkroh andrewkroh mentioned this issue Mar 3, 2019
Merged
andrewkroh added a commit to andrewkroh/beats that referenced this issue Mar 3, 2019
@andrewkroh
Trim project from GCE cloud metadata (elastic#10987)
c57e35b 
This removes the project info from the cloud.machine.type and cloud.availability_zone fields
that are added to the add_cloud_metadata processor for Google Compute Engine (GCE).

Fixes elastic#10968, elastic#10775 (docs)

(cherry picked from commit f527cd5)
andrewkroh added a commit that referenced this issue Mar 6, 2019
@andrewkroh
Trim project from GCE cloud metadata (#10987) (#11052)
bb38a60 
This removes the project info from the cloud.machine.type and cloud.availability_zone fields
that are added to the add_cloud_metadata processor for Google Compute Engine (GCE).

Fixes #10968, #10775 (docs)

(cherry picked from commit f527cd5)
@kaiyan-sheng
Copy link
Contributor

kaiyan-sheng commented Apr 7, 2019 •
edited
Loading

Amazon Elastic Compute Cloud (EC2) should change to Amazon Elastic Compute Cloud (AWS) after elastic/ecs#348 is merged. In the example here https://www.elastic.co/guide/en/beats/filebeat/master/add-cloud-metadata.html, cloud.provider should change from ec2 to aws as well.

PR: #11687

@dedemorton
Copy link
Contributor

@andrewvc Has all the missing content been added? Can we close this issue now?

@botelastic
Copy link

botelastic bot commented Mar 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Mar 18, 2021
@botelastic botelastic bot closed this as completed Apr 17, 2021
@zube zube bot removed the [zube]: Done label Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs ecs :Infra Stalled Team:Integrations Label for the Integrations team v7.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@andrewvc @ruflin @andresrc @andrewkroh @kaiyan-sheng @dedemorton