Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to collects tags in RDS (AWS module) #16358

Closed
tony2k84 opened this issue Feb 15, 2020 · 6 comments · Fixed by #16605
Closed

Add support to collects tags in RDS (AWS module) #16358

tony2k84 opened this issue Feb 15, 2020 · 6 comments · Fixed by #16605
Assignees
Labels
enhancement Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team

Comments

@tony2k84
Copy link

tony2k84 commented Feb 15, 2020

Describe the enhancement:
AWS module - RDS metric set doesn't include tags. This is a very standard mechanism to include specific metadata for resources. All services discovered should have tags.

Describe a specific use case for the enhancement or feature:
Ex. our implementation keeps application name tied to a database (RDS) in the tags object in AWS. There is no way in metric beat to get that information.

@tony2k84 tony2k84 changed the title Add support to collects tags in RDS Add support to collects tags in RDS (was module) Feb 15, 2020
@ycombinator ycombinator added enhancement Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team labels Feb 18, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Feb 25, 2020
@kaiyan-sheng
Copy link
Contributor

@tony2k84 Thanks for reporting this issue. You are absolutely right for needing tags in rds metricset. I just created a PR to add this. Thank you!

@eedugon
Copy link
Contributor

eedugon commented Mar 2, 2020

@kaiyan-sheng , for curiosity... will the PR provide the tags on the RDS events and also allow configuring the metricset to filter certain tags for the input too?

Like with other AWS metricsets where we can filter what to monitor via tags_filter.

@tony2k84
Copy link
Author

tony2k84 commented Mar 2, 2020 via email

@kaiyan-sheng
Copy link
Contributor

@eedugon Sorry I was thinking EC2 metricset needs the tags_filter as well. Turned out it already has it. So I will add tags_filter for RDS in this same PR. Thanks!

@tony2k84 tony2k84 changed the title Add support to collects tags in RDS (was module) Add support to collects tags in RDS (AWS module) Mar 10, 2020
@tony2k84
Copy link
Author

@kaiyan-sheng I am really looking for this to be implemented - any idea on the merge for this one?

@kaiyan-sheng
Copy link
Contributor

@tony2k84 This PR just got merged into master branch. Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants