-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to collects tags in RDS (AWS module) #16358
Comments
@tony2k84 Thanks for reporting this issue. You are absolutely right for needing tags in rds metricset. I just created a PR to add this. Thank you! |
@kaiyan-sheng , for curiosity... will the PR provide the tags on the RDS events and also allow configuring the metricset to filter certain tags for the input too? Like with other AWS metricsets where we can filter what to monitor via |
What is the timeline for tags PR for RDS.
Regards,
Abhishek Tanwar
…________________________________
From: kaiyan-sheng <notifications@github.com>
Sent: Monday, March 2, 2020 4:21:39 PM
To: elastic/beats <beats@noreply.github.com>
Cc: tony2k84 <abhishek.kumartanwar@hotmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [elastic/beats] Add support to collects tags in RDS (was module) (#16358)
Good question @eedugon<https://github.com/eedugon>, I'm planning to add tags_filter for RDS and EC2 metricsets together in a separate PR after this one is merged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#16358?email_source=notifications&email_token=ACX7PLVQMVTO5L64YS5YHA3RFPFIHA5CNFSM4KVXLJHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENPWSYQ#issuecomment-593455458>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACX7PLVXEXQOTP2M3KXRJTTRFPFIHANCNFSM4KVXLJHA>.
|
@eedugon Sorry I was thinking EC2 metricset needs the tags_filter as well. Turned out it already has it. So I will add tags_filter for RDS in this same PR. Thanks! |
@kaiyan-sheng I am really looking for this to be implemented - any idea on the merge for this one? |
@tony2k84 This PR just got merged into master branch. Sorry for the delay! |
Describe the enhancement:
AWS module - RDS metric set doesn't include tags. This is a very standard mechanism to include specific metadata for resources. All services discovered should have tags.
Describe a specific use case for the enhancement or feature:
Ex. our implementation keeps application name tied to a database (RDS) in the tags object in AWS. There is no way in metric beat to get that information.
The text was updated successfully, but these errors were encountered: