Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x-pack-filebeat][windows-7-32] got some failed tests for TestConvertOffsetToString #22315

Closed
v1v opened this issue Oct 30, 2020 · 2 comments · Fixed by #22523
Closed

[x-pack-filebeat][windows-7-32] got some failed tests for TestConvertOffsetToString #22315

v1v opened this issue Oct 30, 2020 · 2 comments · Fixed by #22523
Labels
bug Filebeat Filebeat Team:Services (Deprecated) Label for the former Integrations-Services team windows-7-32 Enable builds in the CI for windows-7 32 bits

Comments

@v1v
Copy link
Member

v1v commented Oct 30, 2020

Failed Test

Stack Trace

[2020-10-30T14:13:52.627Z] 

[2020-10-30T14:13:52.627Z] C:\Users\jenkins\workspace\Beats_beats_PR-19797\src\github.com\elastic\beats\x-pack\filebeat>mage build unitTest 
[2020-10-30T14:14:19.276Z] >> build: Building filebeat
[2020-10-30T14:16:56.153Z] >> go test: Unit Testing
[2020-10-30T14:18:33.422Z] FAILURES:
[2020-10-30T14:18:33.422Z] Package: github.com/elastic/beats/v7/x-pack/filebeat/input/s3
[2020-10-30T14:18:33.422Z] Test:    [build failed]
[2020-10-30T14:18:33.422Z] input\s3\collector_test.go:328:4: constant 123456789123 overflows int
[2020-10-30T14:18:33.422Z] ----
[2020-10-30T14:18:33.422Z] SUMMARY:
[2020-10-30T14:18:33.422Z]   Fail:     1
[2020-10-30T14:18:33.422Z]   Skip:     7
[2020-10-30T14:18:33.422Z]   Pass:     530
[2020-10-30T14:18:33.422Z]   Packages: 20
[2020-10-30T14:18:33.422Z]   Duration: 1m29.859375s
[2020-10-30T14:18:33.422Z]   Coverage Report: C:\Users\jenkins\workspace\Beats_beats_PR-19797\src\github.com\elastic\beats\x-pack\filebeat\build\TEST-go-unit.html
[2020-10-30T14:18:33.422Z]   JUnit Report:    C:\Users\jenkins\workspace\Beats_beats_PR-19797\src\github.com\elastic\beats\x-pack\filebeat\build\TEST-go-unit.xml
[2020-10-30T14:18:33.422Z]   Output File:     C:\Users\jenkins\workspace\Beats_beats_PR-19797\src\github.com\elastic\beats\x-pack\filebeat\build\TEST-go-unit.out
[2020-10-30T14:18:33.422Z] >> go test: Unit Test Failed
[2020-10-30T14:18:33.422Z] Error: go test failed: 1 test failures
script returned exit code 1
@v1v v1v added Filebeat Filebeat windows-7 Enable builds in the CI for windows-7 labels Oct 30, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 30, 2020
@v1v v1v changed the title [x-pack-filebeat][windows-7-64] got some failed tests for TestConvertOffsetToString [x-pack-filebeat][windows-7-32] got some failed tests for TestConvertOffsetToString Oct 30, 2020
@v1v v1v added windows-7-32 Enable builds in the CI for windows-7 32 bits and removed windows-7 Enable builds in the CI for windows-7 labels Oct 30, 2020
@v1v v1v mentioned this issue Oct 30, 2020
Merged
2 tasks
v1v added a commit to v1v/beats that referenced this issue Oct 30, 2020
@v1v
Disable windows-7-32 build for filebeats. See elastic#22315
fe17349
v1v added a commit to v1v/beats that referenced this issue Oct 30, 2020
@v1v
Disable x-pack/filebeat instead filebeat. See elastic#22315
a3e7693
@andresrc andresrc added the Team:Services (Deprecated) Label for the former Integrations-Services team label Oct 31, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 31, 2020
@urso
Copy link

urso commented Nov 10, 2020

The S3 input uses int for all offset computations. This will overflow on any 32bit system.

@urso urso added the bug label Nov 10, 2020
@urso urso mentioned this issue Nov 10, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Filebeat Filebeat Team:Services (Deprecated) Label for the former Integrations-Services team windows-7-32 Enable builds in the CI for windows-7 32 bits
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

S3 offsets should use 64bit integers urso/beats
4 participants
@urso @andresrc @v1v @elasticmachine