Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove functionbeat binaries #40745

Closed
2 tasks
jlind23 opened this issue Sep 11, 2024 · 15 comments · Fixed by #41506
Closed
2 tasks

Remove functionbeat binaries #40745

jlind23 opened this issue Sep 11, 2024 · 15 comments · Fixed by #41506
Assignees
@AndersonQ
Labels
ci Team:Elastic-Agent Label for the Agent team

Comments

@jlind23
Copy link
Collaborator

jlind23 commented Sep 11, 2024 •
edited by AndersonQ
Loading

Functionbeat has now been fully deprecated but binaries are still shipped as part of the standard release process, those should be removed.

cc @strawgate @nimarezainia

  • Remove functionbeat binaries starting from version 9.0
  • Remove functionbeat source code starting from version 9.0

For the record a more detailed list of PRs and issues that are dependencies on other than the beats repo for this task can be found on the PR for this issue:
@jlind23 jlind23 added ci Team:Elastic-Agent Label for the Agent team labels Sep 11, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@jlind23
Copy link
Collaborator Author

jlind23 commented Sep 11, 2024

After chatting with @nimarezainia today we are wondering which one of the approach we should pick:

  • Removing Functionbeat binary and deleting this download page - https://www.elastic.co/downloads/beats/functionbeat
  • Keeping Functionbeat binary but highlighting that this is EOL on the download page itself
  • Switching Functionbeat download page and point to the serverless forwarder download page

@cmacknz @amitkanfer @strawgate any thoughts?

@amitkanfer
Copy link
Collaborator

Switching Functionbeat download page and point to the serverless forwarder download page

Maybe this, and then add a paragraph on the serverless forwarder page that talk about Functionbeat deprecation and a link to an archive?

@jlind23
Copy link
Collaborator Author

jlind23 commented Sep 12, 2024

Maybe this, and then add a paragraph on the serverless forwarder page that talk about Functionbeat deprecation and a link to an archive?

What would be the benefit of mentioning Functionbeat in the Serverless forwarder page?

Switching Functionbeat download page and point to the serverless forwarder download page

@nimarezainia do you know who could help us to that? I guess the team in charge of the release pages?

@nimarezainia
Copy link
Contributor

@jlind23 i'll take care of it. I suppose we need to remove the DRA also?

@jlind23
Copy link
Collaborator Author

jlind23 commented Sep 12, 2024

I suppose we need to remove the DRA also?

So you mean that we don't want to push binaries anymore?

@cmacknz
Copy link
Member

cmacknz commented Sep 12, 2024

The least disruptive option is to remove the binaries completely in 9.0 and keep them around on 8.x.

If we can I would completely delete the functionbeat source code in the 9.0 branch, with it only existing in 8.x.

@jlind23
Copy link
Collaborator Author

jlind23 commented Sep 12, 2024

Thanks @cmacknz, added the two related actions in the description.

@nimarezainia
Copy link
Contributor

Thanks @cmacknz, added the two related actions in the description.

Just to clarify - target removal of the download page at 9.0 as well?

@jlind23
Copy link
Collaborator Author

jlind23 commented Sep 13, 2024

Just to clarify - target removal of the download page at 9.0 as well?

Yes.

@kilfoyle kilfoyle mentioned this issue Nov 4, 2024
Closed
@AndersonQ AndersonQ mentioned this issue Nov 5, 2024
Merged
2 tasks
@pierrehilbert
Copy link
Collaborator

pierrehilbert commented Nov 5, 2024 •
edited
Loading

After discussing with @AndersonQ, this issue is a Small in terms of work but requires sync with other teams and to have things in motion so could take more than the sprint to have it through the finish line.

AndersonQ added a commit to elastic/kibana that referenced this issue Nov 5, 2024
@AndersonQ
kbn-doc-links: remove functionbeat (#198902)
4e753fa 
## Summary

Remove docs link to functionbeat as it has been deprecated and will be
removed in 9.0

### Checklist

Delete any items that are not applicable to this PR.


### Risk Matrix

Delete this section if it is not applicable to this PR.

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Related Issues:
 - Closes #193030
 - Relates elastic/beats#40745
@AndersonQ AndersonQ mentioned this issue Nov 5, 2024
Closed
3 tasks
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 6, 2024
@AndersonQ
kbn-doc-links: remove functionbeat (elastic#198902)
40771c7 
## Summary

Remove docs link to functionbeat as it has been deprecated and will be
removed in 9.0

### Checklist

Delete any items that are not applicable to this PR.

### Risk Matrix

Delete this section if it is not applicable to this PR.

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Related Issues:
 - Closes elastic#193030
 - Relates elastic/beats#40745

(cherry picked from commit 4e753fa)
kilfoyle pushed a commit to kilfoyle/kibana that referenced this issue Nov 6, 2024
@AndersonQ @kilfoyle
kbn-doc-links: remove functionbeat (elastic#198902)
722e558 
## Summary

Remove docs link to functionbeat as it has been deprecated and will be
removed in 9.0

### Checklist

Delete any items that are not applicable to this PR.


### Risk Matrix

Delete this section if it is not applicable to this PR.

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Related Issues:
 - Closes elastic#193030
 - Relates elastic/beats#40745
mgadewoll pushed a commit to mgadewoll/kibana that referenced this issue Nov 7, 2024
@AndersonQ @mgadewoll
kbn-doc-links: remove functionbeat (elastic#198902)
6db5d88 
## Summary

Remove docs link to functionbeat as it has been deprecated and will be
removed in 9.0

### Checklist

Delete any items that are not applicable to this PR.


### Risk Matrix

Delete this section if it is not applicable to this PR.

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Related Issues:
 - Closes elastic#193030
 - Relates elastic/beats#40745
This was referenced Nov 7, 2024
Merged
Merged
AndersonQ added a commit to elastic/kibana that referenced this issue Nov 13, 2024
@AndersonQ
Remove functionbeat tutorial and translations (#199301)
710c4cc 
## Summary

Remove functionbeat tutorial and translations. It's been deprecated and won't be
shipped on 9.0

### Checklist

Delete any items that are not applicable to this PR.

### Risk Matrix

I'm not sure, its just deleting code/documentation

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Related issues

- Relates elastic/beats#40745
- #193030
AndersonQ added a commit to AndersonQ/kibana that referenced this issue Nov 13, 2024
@AndersonQ
Remove functionbeat tutorial and translations (elastic#199301)
278f817 
## Summary

Remove functionbeat tutorial and translations. It's been deprecated and won't be
shipped on 9.0

### Checklist

Delete any items that are not applicable to this PR.

### Risk Matrix

I'm not sure, its just deleting code/documentation

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Related issues

- Relates elastic/beats#40745
- elastic#193030

(cherry picked from commit 710c4cc)

# Conflicts:
#	api_docs/telemetry.devdocs.json
#	x-pack/plugins/translations/translations/zh-CN.json
AndersonQ added a commit to AndersonQ/kibana that referenced this issue Nov 13, 2024
@AndersonQ
Remove functionbeat tutorial and translations (elastic#199301)
8bd9010 
## Summary

Remove functionbeat tutorial and translations. It's been deprecated and won't be
shipped on 9.0

### Checklist

Delete any items that are not applicable to this PR.

### Risk Matrix

I'm not sure, its just deleting code/documentation

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Related issues

- Relates elastic/beats#40745
- elastic#193030

(cherry picked from commit 710c4cc)

# Conflicts:
#	api_docs/telemetry.devdocs.json
#	x-pack/plugins/translations/translations/zh-CN.json
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 18, 2024
@AndersonQ @CAWilson94
Remove functionbeat tutorial and translations (elastic#199301)
57de872 
## Summary

Remove functionbeat tutorial and translations. It's been deprecated and won't be
shipped on 9.0

### Checklist

Delete any items that are not applicable to this PR.

### Risk Matrix

I'm not sure, its just deleting code/documentation

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Related issues

- Relates elastic/beats#40745
- elastic#193030
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 18, 2024
@AndersonQ @CAWilson94
Remove functionbeat tutorial and translations (elastic#199301)
8338587 
## Summary

Remove functionbeat tutorial and translations. It's been deprecated and won't be
shipped on 9.0

### Checklist

Delete any items that are not applicable to this PR.

### Risk Matrix

I'm not sure, its just deleting code/documentation

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
- [ ] This will appear in the **Release Notes** and follow the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Related issues

- Relates elastic/beats#40745
- elastic#193030
@AndersonQ
Copy link
Member

As it's clear on the beats PR for this issue, removing function betas also affects Kibana. One of the affected features is the ability to track telemetry regarding functionbeat as Abdul Zahid pointed out here. Those were not removed for now. I myself believe we can keep them, but ultimately it's a product decision. So @strawgate @nimarezainia as you two are in cc for this issue, I believe you might be able to help me here in deciding if we should keep or not the tracking of functionbeat telemetry in 9.0.

cc: @pierrehilbert @cmacknz

@nimarezainia
Copy link
Contributor

As it's clear on the beats PR for this issue, removing function betas also affects Kibana. One of the affected features is the ability to track telemetry regarding functionbeat as Abdul Zahid pointed out here. Those were not removed for now. I myself believe we can keep them, but ultimately it's a product decision. So @strawgate @nimarezainia as you two are in cc for this issue, I believe you might be able to help me here in deciding if we should keep or not the tracking of functionbeat telemetry in 9.0.

cc: @pierrehilbert @cmacknz

keeping the tracking telemetry in there is fine IMO.

@jlind23
Copy link
Collaborator Author

jlind23 commented Dec 9, 2024

@nimarezainia @AndersonQ as we decided to keep telemetry, are we good to close this issue as done?

@nimarezainia
Copy link
Contributor

@nimarezainia @AndersonQ as we decided to keep telemetry, are we good to close this issue as done?

sure. when the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndersonQ AndersonQ

Labels
ci Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove functionbeat AndersonQ/beats
7 participants
@AndersonQ @pierrehilbert @amitkanfer @cmacknz @nimarezainia @elasticmachine @jlind23