Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Run Agentbeat integration tests on Windows 2022 #41058

Open
ycombinator opened this issue Oct 1, 2024 · 1 comment
Open

[CI] Run Agentbeat integration tests on Windows 2022 #41058

ycombinator opened this issue Oct 1, 2024 · 1 comment
Labels
ci needs_team Indicates that the issue/PR needs a Team:* label

Comments

@ycombinator
Copy link
Contributor

Currently, we run Agentbeat integration tests only on Linux:

- label: ":linux: Agentbeat/Integration tests Linux"
key: "agentbeat-it-linux"
depends_on:
- agentbeat-package-linux
env:
ASDF_NODEJS_VERSION: 18.17.1
PLATFORMS: "+all linux/amd64 linux/arm64 windows/amd64 darwin/amd64 darwin/arm64"
SNAPSHOT: true
command: |
set -euo pipefail
echo "~~~ Downloading artifacts"
buildkite-agent artifact download x-pack/agentbeat/build/distributions/** . --step 'agentbeat-package-linux'
ls -lah x-pack/agentbeat/build/distributions/
echo "~~~ Installing @elastic/synthetics with npm"
npm install -g @elastic/synthetics
echo "~~~ Running tests"
cd x-pack/agentbeat
mage goIntegTest
artifact_paths:
- x-pack/agentbeat/build/distributions/**/*
- "x-pack/agentbeat/build/*.xml"
- "x-pack/agentbeat/build/*.json"
retry:
automatic:
- limit: 1
timeout_in_minutes: 60
agents:
provider: "gcp"
image: "${IMAGE_UBUNTU_X86_64}"
machineType: "${GCP_HI_PERF_MACHINE_TYPE}"
disk_size: 100
disk_type: "pd-ssd"
notify:
- github_commit_status:
context: "agentbeat: Integration tests"

This has led to at least one Windows-specific bug not being detected in Beats CI, which led to this revert PR: #41009.

We should also run Agentbeat integration tests on Windows, specifically Windows 2022 as Elastic Agent integration tests run on this platform in CI.

@ycombinator ycombinator added the ci label Oct 1, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 1, 2024
@botelastic
Copy link

botelastic bot commented Oct 1, 2024

This issue doesn't have a Team:<team> label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

No branches or pull requests

1 participant