Revert "[winlogbeat] Add handling for missing event data types in the experimental API" #41009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
mergify
bot
added
the
backport-8.x
ycombinator
added
the
Team:Security-Windows Platform
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
andrewkroh
approved these changes
Sep 26, 2024
intxgo
approved these changes
Sep 26, 2024
We're reverting because Elastic Agent CI has been failing and we've narrowed it down to the type assertion failing here and not checking `ok` right after: https://github.com/elastic/beats/blob/138e43cad7eda93c1414641682056b6c88efcf1d/winlogbeat/sys/strings_windows.go#L31-L32 Specifically, when integration tests for Elastic Agent run on its CI Windows hosts, we are seeing this failure in the log: ``` panic: runtime error: invalid memory address or nil pointer dereference [signal 0xc0000005 code=0x0 addr=0x0 pc=0x284f4bf] goroutine 1 [running]: golang.org/x/text/encoding/charmap.(*Charmap).ID(0x0) /go/pkg/mod/golang.org/x/text@v0.18.0/encoding/charmap/charmap.go:111 +0x1f github.com/elastic/beats/v7/winlogbeat/sys.init.0() /go/src/github.com/elastic/beats/winlogbeat/sys/strings_windows.go:32 +0x10c ```
ycombinator
force-pushed
the
revert-40684-feat/add-types-win-exp
branch
from
1c3297b
to
6055af7
Compare
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
We're reverting because Elastic Agent CI has been failing and we've narrowed it down to the type assertion failing here and not checking `ok` right after: https://github.com/elastic/beats/blob/138e43cad7eda93c1414641682056b6c88efcf1d/winlogbeat/sys/strings_windows.go#L31-L32 Specifically, when integration tests for Elastic Agent run on its CI Windows hosts, we are seeing this failure in the log: ``` panic: runtime error: invalid memory address or nil pointer dereference [signal 0xc0000005 code=0x0 addr=0x0 pc=0x284f4bf] goroutine 1 [running]: golang.org/x/text/encoding/charmap.(*Charmap).ID(0x0) /go/pkg/mod/golang.org/x/text@v0.18.0/encoding/charmap/charmap.go:111 +0x1f github.com/elastic/beats/v7/winlogbeat/sys.init.0() /go/src/github.com/elastic/beats/winlogbeat/sys/strings_windows.go:32 +0x10c ``` (cherry picked from commit 307e95c)
ycombinator
added a commit
that referenced
this pull request
Sep 26, 2024
We're reverting because Elastic Agent CI has been failing and we've narrowed it down to the type assertion failing here and not checking `ok` right after: https://github.com/elastic/beats/blob/138e43cad7eda93c1414641682056b6c88efcf1d/winlogbeat/sys/strings_windows.go#L31-L32 Specifically, when integration tests for Elastic Agent run on its CI Windows hosts, we are seeing this failure in the log: ``` panic: runtime error: invalid memory address or nil pointer dereference [signal 0xc0000005 code=0x0 addr=0x0 pc=0x284f4bf] goroutine 1 [running]: golang.org/x/text/encoding/charmap.(*Charmap).ID(0x0) /go/pkg/mod/golang.org/x/text@v0.18.0/encoding/charmap/charmap.go:111 +0x1f github.com/elastic/beats/v7/winlogbeat/sys.init.0() /go/src/github.com/elastic/beats/winlogbeat/sys/strings_windows.go:32 +0x10c ``` (cherry picked from commit 307e95c) Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #40684
We're reverting because Elastic Agent CI has been failing and we've narrowed it down to the type assertion failing here and not checking
okright after:beats/winlogbeat/sys/strings_windows.go
Lines 31 to 32 in 138e43c
Specifically, when integration tests for Elastic Agent run on its CI Windows hosts, we are seeing this failure in the log: