Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong "make collect" statement documented instead of "make update" when documentation should be regenerated #4154

Closed
christiangalsterer opened this issue May 1, 2017 · 2 comments
Closed

Wrong "make collect" statement documented instead of "make update" when documentation should be regenerated #4154

christiangalsterer opened this issue May 1, 2017 · 2 comments
Labels
docs

Comments

@christiangalsterer
Copy link
Contributor

https://www.elastic.co/guide/en/beats/metricbeat/current/creating-metricbeat-module.html
documents that the user should run make collect when some of the documentation input fields are changed and the documentation should be regenerated. The correct command to run is make update.
christiangalsterer added a commit to christiangalsterer/beats that referenced this issue May 1, 2017
@christiangalsterer
[elastic#4154] Wrong "make collect" statement documented instead of "…
1932b6a 
…make update" when documentation should be regenerated
@christiangalsterer
Copy link
Contributor Author

PR #4155 available

ruflin pushed a commit that referenced this issue May 1, 2017
@christiangalsterer @ruflin
[#4154] Wrong "make collect" statement documented instead of "make up…
4cec36a 
…date" when documentation should be regenerated (#4155)
dedemorton pushed a commit to dedemorton/beats that referenced this issue May 6, 2017
@christiangalsterer @dedemorton
[elastic#4154] Wrong "make collect" statement documented instead of "…
f54e438 
…make update" when documentation should be regenerated (elastic#4155)
ruflin pushed a commit that referenced this issue May 8, 2017
@christiangalsterer @ruflin
[#4154] Wrong "make collect" statement documented instead of "make up…
ff1be98 
…date" when documentation should be regenerated (#4155)
@andrewkroh
Copy link
Member

Fixed by #4155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewkroh @christiangalsterer