Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document backoff setting #5419

Closed
1 task done
urso opened this issue Oct 23, 2017 · 5 comments · Fixed by #6903
Closed
1 task done

Document backoff setting #5419

urso opened this issue Oct 23, 2017 · 5 comments · Fixed by #6903

Comments

@urso
Copy link

urso commented Oct 23, 2017

Output Backoff parameters have become configurable. Add missing settings to docs:

Note: check all outputs expose backoff settings

@dedemorton
Copy link
Contributor

@urso It looks like these settings aren't shown in the reference.yml files. Do we still want to document these? Looks like Logstash, Elasticsearch, and Kafka all have backoff settings. I can help add the content to the docs, but I don't see the options in the reference.yml.

@ruflin
Copy link
Contributor

ruflin commented Mar 26, 2018

We should also add them to the reference file if they are missing.

@urso
Copy link
Author

urso commented Apr 6, 2018

Checking the code, we have different backoff behavior/config per output.

Elasticsearch/Logstash have backoff.init and backoff.max settings. Both employ exponential backoff, with init (default=1s) being the initial waiting time and max (default=60s) being the max waiting time.

The kafka backoff setting is available regarding the meta-data update only. Setting is output.kafka.metadata.retry.backoff. Unfortunately the client doesn't always handle backoff correctly. This needs to be resolved.

Checking the redis output, we don't have any backoff settings in here.

If backoff settings are missing from reference.yml, they should be added as well. Anyways, backoff behavior needs some overhaul, so we can guarantee same settings/semantics for all outputs.

@urso
Copy link
Author

urso commented Apr 6, 2018

I created issue: #6791

For now let's add only Elasticsearch and Logstash to the reference configs only.

@dedemorton
Copy link
Contributor

I've added the backoff settings for the ES and LS outputs here: #5419.

urso pushed a commit that referenced this issue Jun 13, 2018
Adds backoff options for LS and ES outputs (closes #5419)
dedemorton added a commit to dedemorton/beats that referenced this issue Jun 18, 2018
Adds backoff options for LS and ES outputs (closes elastic#5419)
ruflin pushed a commit that referenced this issue Jun 19, 2018
Adds backoff options for LS and ES outputs (closes #5419)
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
Adds backoff options for LS and ES outputs (closes elastic#5419)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants