Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metricbeat MongoDB Connection Leak #5688

Closed
andrewkroh opened this issue Nov 22, 2017 · 1 comment
Closed

Metricbeat MongoDB Connection Leak #5688

andrewkroh opened this issue Nov 22, 2017 · 1 comment
Labels
bug good first issue Indicates a good issue for first-time contributors Metricbeat Metricbeat

Comments

@andrewkroh
Copy link
Member

andrewkroh commented Nov 22, 2017 •
edited
Loading

Each of the MongoDB metricsets (status, dbstats) create a new session for each Fetch by do not close the session that they open. Each metricset should have a defer session.Close() (or similar).

beats/metricbeat/module/mongodb/status/status.go

Line 62 in 84e2e09

mongoSession, err := mongodb.NewDirectSession(m.dialInfo)

beats/metricbeat/module/mongodb/dbstats/dbstats.go

Line 60 in 84e2e09

mongoSession, err := mongodb.NewDirectSession(m.dialInfo)

For confirmed bugs, please report:
@andrewkroh
Copy link
Member Author

andrewkroh commented Nov 22, 2017 •
edited
Loading

I haven't verified this bug. My report is based on code inspection and a user report from Discuss.

@andrewkroh andrewkroh added the good first issue Indicates a good issue for first-time contributors label Nov 22, 2017
@mountkin mountkin mentioned this issue Nov 25, 2017
Merged
This was referenced Nov 28, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Indicates a good issue for first-time contributors Metricbeat Metricbeat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewkroh