Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix connection leak in the mongodb module #5711

Merged
merged 1 commit into from
Nov 27, 2017
Merged

fix connection leak in the mongodb module #5711

merged 1 commit into from
Nov 27, 2017

Conversation

mountkin
Copy link
Contributor

Fixes #5688

@elasticmachine
Copy link
Collaborator

Can one of the admins verify this patch?

@mountkin
Copy link
Contributor Author

CLA signed

@kvch
Copy link
Contributor

kvch commented Nov 25, 2017

jenkins, test it

@ruflin
Copy link
Contributor

ruflin commented Nov 26, 2017

Thanks for fixing this. I think we missed that change in #5120 where we moved it from init to fetch. Previously it was just one connection we leaked, now it can be many more.

@ruflin
Copy link
Contributor

ruflin commented Nov 26, 2017

@mountkin Could you add an entry to the Changelog file?

@ruflin ruflin added bug Metricbeat Metricbeat review needs_backport PR is waiting to be backported to other branches. labels Nov 26, 2017
@mountkin
fix connection leak in the mongodb module
56ade9a 
Signed-off-by: Shijiang Wei <mountkin@gmail.com>
@mountkin
Copy link
Contributor Author

@ruflin Changelog entry added

ruflin
ruflin approved these changes Nov 27, 2017
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenkins, test it

@exekias exekias merged commit f9a18c1 into elastic:master Nov 27, 2017
@exekias
Copy link
Contributor

exekias commented Nov 27, 2017

Thank you so much @mountkin!

ruflin pushed a commit to ruflin/beats that referenced this pull request Nov 28, 2017
@mountkin @ruflin
fix connection leak in the mongodb module (elastic#5711)
5f351e2 
Signed-off-by: Shijiang Wei <mountkin@gmail.com>
(cherry picked from commit f9a18c1)
@ruflin ruflin mentioned this pull request Nov 28, 2017
Merged
@ruflin ruflin removed the needs_backport PR is waiting to be backported to other branches. label Nov 28, 2017
ruflin pushed a commit to ruflin/beats that referenced this pull request Nov 28, 2017
@mountkin @ruflin
fix connection leak in the mongodb module (elastic#5711)
b57d648 
Signed-off-by: Shijiang Wei <mountkin@gmail.com>
(cherry picked from commit f9a18c1)
@ruflin ruflin mentioned this pull request Nov 28, 2017
Merged
andrewkroh pushed a commit that referenced this pull request Nov 29, 2017
@ruflin @andrewkroh
fix connection leak in the mongodb module (#5711) (#5743)
26afa60 
Signed-off-by: Shijiang Wei <mountkin@gmail.com>
(cherry picked from commit f9a18c1)
andrewkroh pushed a commit that referenced this pull request Nov 29, 2017
@ruflin @andrewkroh
fix connection leak in the mongodb module (#5711) (#5742)
a64b4c7 
Signed-off-by: Shijiang Wei <mountkin@gmail.com>
(cherry picked from commit f9a18c1)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@ruflin @andrewkroh
fix connection leak in the mongodb module (elastic#5711) (elastic#5743)
1e7df61 
Signed-off-by: Shijiang Wei <mountkin@gmail.com>
(cherry picked from commit b11ca76)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@ruflin @andrewkroh
fix connection leak in the mongodb module (elastic#5711) (elastic#5742)
f04696d 
Signed-off-by: Shijiang Wei <mountkin@gmail.com>
(cherry picked from commit b11ca76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
bug Metricbeat Metricbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mountkin @elasticmachine @kvch @ruflin @exekias