Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate the Central management access tokens #9621

Closed
ph opened this issue Dec 18, 2018 · 0 comments
Closed

Validate the Central management access tokens #9621

ph opened this issue Dec 18, 2018 · 0 comments
Labels
bug Management

Comments

@ph
Copy link
Contributor

ph commented Dec 18, 2018

Add validation when we receives the token from Kibana to make sure we do not have an empty string.

Assert that the token is not an empty string before fetching the configuration from kibana, the token is saved in the keystore and user could modify that.
@ph ph changed the title Validate the tokens Validate the Central management access tokens Dec 18, 2018
ph added a commit to ph/beats that referenced this issue Dec 18, 2018
@ph
Be more strict when handling the access token
eccaf49 
Add validations for the Kibana response with the access token,
and enforce that the access token is not empty when unpacking the
configuration. Since the access token in the keystore could be edited.

Fixes: elastic#9621
@ph ph mentioned this issue Dec 18, 2018
Merged
@ph ph closed this as completed in #9624 Dec 18, 2018
ph added a commit that referenced this issue Dec 18, 2018
@ph
Be more strict when handling the access token (#9624)
8dd740f 
Add validations for the Kibana response with the access token,
and enforce that the access token is not empty when unpacking the
configuration. Since the access token in the keystore could be edited.

Fixes: #9621
ph added a commit to ph/beats that referenced this issue Dec 18, 2018
@ph
Be more strict when handling the access token (elastic#9624)
8046c81 
Add validations for the Kibana response with the access token,
and enforce that the access token is not empty when unpacking the
configuration. Since the access token in the keystore could be edited.

Fixes: elastic#9621
(cherry picked from commit 8dd740f)
@ph ph mentioned this issue Dec 18, 2018
Merged
ph added a commit that referenced this issue Dec 19, 2018
@ph
Cherry-pick #9624 to 6.x: Be more strict when handling the access tok…
c42897b 
…en (#9643)

Cherry-pick of PR #9624 to 6.x branch. Original message: 

Add validations for the Kibana response with the access token,
and enforce that the access token is not empty when unpacking the
configuration. Since the access token in the keystore could be edited.

Fixes: #9621
ph added a commit to ph/beats that referenced this issue Dec 24, 2018
@ph
Be more strict when handling the access token (elastic#9624)
f49e43c 
Add validations for the Kibana response with the access token,
and enforce that the access token is not empty when unpacking the
configuration. Since the access token in the keystore could be edited.

Fixes: elastic#9621
(cherry picked from commit 8dd740f)
@ph ph mentioned this issue Dec 24, 2018
Merged
ph added a commit to ph/beats that referenced this issue Dec 24, 2018
@ph
Be more strict when handling the access token (elastic#9624)
f5f690f 
Add validations for the Kibana response with the access token,
and enforce that the access token is not empty when unpacking the
configuration. Since the access token in the keystore could be edited.

Fixes: elastic#9621
(cherry picked from commit 8dd740f)
@ph ph mentioned this issue Dec 24, 2018
Closed
ph added a commit that referenced this issue Jan 8, 2019
@ph
Cherry-pick #9624 to 6.5: Be more strict when handling the access tok…
f8142f4 
…en (#9790)

Cherry-pick of PR #9624 to 6.5 branch. Original message: 

Add validations for the Kibana response with the access token,
and enforce that the access token is not empty when unpacking the
configuration. Since the access token in the keystore could be edited.

Fixes: #9621
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
@ph
Cherry-pick elastic#9624 to 6.5: Be more strict when handling the acc…
3014241 
…ess token (elastic#9790)

Cherry-pick of PR elastic#9624 to 6.5 branch. Original message: 

Add validations for the Kibana response with the access token,
and enforce that the access token is not empty when unpacking the
configuration. Since the access token in the keystore could be edited.

Fixes: elastic#9621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Management
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ph