Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Filebeat mysql.* to ECS #10008

Merged
merged 11 commits into from
Jan 11, 2019
Merged

Convert Filebeat mysql.* to ECS #10008

merged 11 commits into from
Jan 11, 2019

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Jan 11, 2019

Caveats

  • Got rid of workaround for an Ingest Node issue fixed in 5.0, in 2016

Renames

  • mysql.error.message => message
  • mysql.error.level => log.level
  • mysql.error.thread_id => process.thread.id
  • mysql.slowlog.ip => source.ip
  • mysql.slowlog.host => source.domain
  • mysql.slowlog.user => user.name

TODO

  • Add -expected.json log for the error logs
  • Get rid of workaround for Ingest Node's grok can't set the same field from two patterns elasticsearch#22117, which was fixed in 5.0
  • Set event.created
  • Coerce int fields: process.thread.id, mysql.slowlog.id, mysql.slowlog.rows_sent, mysql.slowlog.rows_examined and mysql.slowlog.timestamp
  • Coerce float fields: mysql.slowlog.query_time.sec, mysql.slowlog.lock_time.sec
  • Populate event.duration based on mysql.slowlog.query_time.sec
  • Alias renamed fields to their ECS counterpart, not forgetting migration: true
  • Document field migrations in ecs-migration.yml
  • Changelog

@webmat webmat requested review from a team as code owners January 11, 2019 04:59
@webmat webmat self-assigned this Jan 11, 2019
@webmat webmat requested a review from ruflin January 11, 2019 05:02
@ruflin ruflin mentioned this pull request Jan 11, 2019
@webmat
Copy link
Contributor Author

webmat commented Jan 11, 2019

jenkins, test this

@urso urso removed the request for review from a team January 11, 2019 14:57
@webmat webmat merged commit 383ccce into elastic:master Jan 11, 2019
@webmat webmat deleted the ecs-mysql-fb branch January 11, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants