-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fields labels #10119
Merged
Merged
Add fields labels #10119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
added
review
needs_backport
PR is waiting to be backported to other branches.
labels
Jan 16, 2019
houndci-bot
reviewed
Jan 16, 2019
ruflin
approved these changes
Jan 17, 2019
ruflin
approved these changes
Jan 18, 2019
jenkins, test this |
ph
approved these changes
Jan 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will need rebase.
The error is related to TLS on hearthbeat, first time I've seen it.
23:20:25 --- FAIL: TestHTTPSx509Auth (1.32s)
23:20:25 <autogenerated>:1:
23:20:25 Error Trace: mapvaltest.go:40
23:20:25 Error: mapval could not validate map
23:20:25 Test: TestHTTPSx509Auth
23:20:25 Messages: 13 errors validating source:
23:20:25 (common.MapStr) (len=4) {"error":{"message":"Get https://127.0.0.1:45821: read tcp 127.0.0.1:39022-\u003e127.0.0.1:45821: i/o timeout (Client.Timeout exceeded while awaiting headers)","type":"io"},"monitor":{"duration":{"us":1013787},"ip":"127.0.0.1","status":"down"},"tcp":{"rtt":{"connect":{"us":2023}}},"url":{"domain":"127.0.0.1","full":"https://127.0.0.1:45821","port":255,"scheme":"https"}}
23:20:25 <autogenerated>:1:
23:20:25 Error Trace: mapvaltest.go:48
23:20:25 Error: Received unexpected error:
23:20:25 @path 'error': unexpected field encountered during strict validation
23:20:25 Test: TestHTTPSx509Auth
23:20:25 <autogenerated>:1:
23:20:25 Error Trace: mapvaltest.go:48
23:20:25 Error: Received unexpected error:
23:20:25 @path 'monitor.status': objects not equal: actual(down) != expected(up)
23:20:25 Test: TestHTTPSx509Auth
23:20:25 <autogenerated>:1:
23:20:25 Error Trace: mapvaltest.go:48
23:20:25 Error: Received unexpected error:
23:20:25 @path 'tls.rtt.handshake.us': expected this key to be present
23:20:25 Test: TestHTTPSx509Auth
23:20:25 <autogenerated>:1:
23:20:25 Error Trace: mapvaltest.go:48
23:20:25 Error: Received unexpected error:
23:20:25 @path 'http.rtt.validate.us': expected this key to be present
23:20:25 Test: TestHTTPSx509Auth
23:20:25 <autogenerated>:1:
23:20:25 Error Trace: mapvaltest.go:48
23:20:25 Error: Received unexpected error:
23:20:25 @path 'http.rtt.content.us': expected this key to be present
23:20:25 Test: TestHTTPSx509Auth
23:20:25 <autogenerated>:1:
23:20:25 Error Trace: mapvaltest.go:48
23:20:25 Error: Received unexpected error:
23:20:25 @path 'http.rtt.write_request.us': expected this key to be present
23:20:25 Test: TestHTTPSx509Auth
23:20:25 <autogenerated>:1:
23:20:25 Error Trace: mapvaltest.go:48
23:20:25 Error: Received unexpected error:
23:20:26 @path 'tls.certificate_not_valid_before': expected this key to be present
23:20:26 Test: TestHTTPSx509Auth
23:20:26 <autogenerated>:1:
23:20:26 Error Trace: mapvaltest.go:48
23:20:26 Error: Received unexpected error:
23:20:26 @path 'tls.certificate_not_valid_after': expected this key to be present
23:20:26 Test: TestHTTPSx509Auth
23:20:26 <autogenerated>:1:
23:20:26 Error Trace: mapvaltest.go:48
23:20:26 Error: Received unexpected error:
23:20:26 @path 'http.response.status_code': expected this key to be present
23:20:26 Test: TestHTTPSx509Auth
23:20:26 <autogenerated>:1:
23:20:26 Error Trace: mapvaltest.go:48
23:20:26 Error: Received unexpected error:
23:20:26 @path 'http.rtt.response_header.us': expected this key to be present
23:20:26 Test: TestHTTPSx509Auth
23:20:26 <autogenerated>:1:
23:20:26 Error Trace: mapvaltest.go:48
23:20:26 Error: Received unexpected error:
23:20:26 @path 'error.message': unexpected field encountered during strict validation
23:20:26 Test: TestHTTPSx509Auth
23:20:26 <autogenerated>:1:
23:20:26 Error Trace: mapvaltest.go:48
23:20:26 Error: Received unexpected error:
23:20:26 @path 'http.rtt.total.us': expected this key to be present
23:20:26 Test: TestHTTPSx509Auth
23:20:26 <autogenerated>:1:
23:20:26 Error Trace: mapvaltest.go:48
23:20:26 Error: Received unexpected error:
23:20:26 @path 'error.type': unexpected field encountered during strict validation
23:20:26 Test: TestHTTPSx509Auth
23:20:26 FAIL
The add_labels processor was more similar to the fields setting. This change introduces the add_fields processor to behave like the fields setting, but changes/limits the add_labels procesor to the use case of adding a flat set of labels to ECS compatible events. The add_labels processor will: - flatten keys by joining nested names with dots - always writes labels to the events 'labels' field. The target field is not configurable and labels can not be written to the root of the document
urso
force-pushed
the
add-fields-labels
branch
from
January 21, 2019 18:09
2d79ded
to
fb9b01b
Compare
urso
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The add_labels processor was more similar to the fields setting.
This change introduces the add_fields processor to behave like the
fields setting, but changes/limits the add_labels procesor to the use
case of adding a flat set of labels to ECS compatible events.
The add_labels processor will:
not configurable and labels can not be written to the root of the
document