-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated --setup, --version, and --configflags CLI flags #10138
Conversation
883996d
to
e51c7d9
Compare
The package
I have found a few instaces of
Nit: One more comment referring to // handleFlags parses the command line flags. It handles the '-version' flag
// and invokes the HandleFlags callback if implemented by the Beat.
func (b *Beat) handleFlags() error { |
@kvch Thanks. These settings are everywhere :) |
beats-ci is acting up once again :( Travis is green + related windows tests have been green as well: https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-windows/beat=winlogbeat,label=windows/3948/console |
Jenkins, test this. |
59edd77
to
59301d1
Compare
----- | ||
|
||
Or: | ||
|
||
["source","sh",subs="attributes"] | ||
----- | ||
{beatname_lc} -e --setup | ||
{beatname_lc} -e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also remove the sentence on line 571/572 that says: "Use this command instead of run --setup
when you want to set up the environment without actually running {beatname_uc} and ingesting data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I modified the sentence to:
Use this command if you want to set up the environment without actually running
{beatname_uc} and ingesting data.
59301d1
to
ec12eed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc changes LGTM
…astic#10138) * Remove deprecated --setup and --version, and -configtest flags
Remove flags and references from: