Allow specifying Kibana URL for mage ExportDashboard #10145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 17, 2019
ruflin
reviewed
Jan 17, 2019
dev-tools/mage/dashboard.go
Outdated
| @@ -36,6 +36,8 @@ func ExportDashboard() error { | |||
| return fmt.Errorf("Dashboad ID must be specified") | |||
| } | |||
|
|
|||
| kibanaURL := EnvOr("KIBANA", "") | |||
There was a problem hiding this comment.
Should we call this KIBANA_BASE_PATH because to remove it in the kibana build you need to run --no-base-path flag.
There was a problem hiding this comment.
I prefer KIBANA_URL. That's what I used in the import target in the PR.
https://github.com/elastic/beats/pull/9842/files#diff-81a661bb38d6e9e450c732a07bdb4ac0R63
There was a problem hiding this comment.
I'm fine with either.
There was a problem hiding this comment.
me too, KIBANA_URL then? :-)
|
I've changed to |
|
jenkins, test this |
ruflin
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Kibana from source (maybe also in other cases) Kibana will run under a URL like
http://localhost:5603/kva(note thekvaat the end).This changes the
mage ExportDashboardcommand to take into account aKIBANA_URLenvironment variable that allows specifying a custom Kibana URL like that to allow exporting dashboards.Also improves a log message.