Rename thread id fields in filebeat module for mysql #10161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
module
review
Filebeat
Several ids in the filebeat module for mysql are named differently but they all refer to thread (or connection) ids. They are internal mysql ids that don't map to operating system processes or threads. Use `mysql.thread_id` for these ids. Also remove timestamp fields after converting them to dates.
jsoriano
force-pushed
the
mysql-thread-id
branch
from
62ad62b to
e8e82ec
Compare
ruflin
approved these changes
Jan 18, 2019
|
jenkins test this |
|
Test failure not related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several ids in the filebeat module for mysql are named differently but
they all refer to thread (or connection) ids. They are internal mysql
ids that don't map to operating system processes or threads.
Use
mysql.thread_idfor these ids.Also remove timestamp fields after converting them to dates.
Follow-up of #9731