Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making RabbitMQ Metricbeat module GA. #10165

Merged
merged 2 commits into from
Jan 21, 2019
Merged

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Jan 18, 2019

No description provided.

@ruflin ruflin added module review Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Jan 18, 2019
@ruflin ruflin self-assigned this Jan 18, 2019
@ruflin ruflin requested review from a team as code owners January 18, 2019 12:05
@ruflin ruflin added the needs_backport PR is waiting to be backported to other branches. label Jan 18, 2019
@jsoriano
Copy link
Member

It'd be nice to have #10014 before this is released.

@ruflin
Copy link
Contributor Author

ruflin commented Jan 18, 2019

@jsoriano SGTM. But I think it's not a blocker, we can still do a bug fix release with it. Will try to update the data.json file.

@jsoriano
Copy link
Member

Umm, docs build is failing, not sure if related.

@ruflin
Copy link
Contributor Author

ruflin commented Jan 21, 2019

@jsoriano I have seen a similar flaky doc build failures on other PR's. Never investigated so far but should. Restarting CI for now as it also failed on travis.

@ruflin ruflin merged commit 68bd655 into elastic:master Jan 21, 2019
@ruflin ruflin deleted the rabbitmq-ga branch January 21, 2019 15:21
ruflin added a commit to ruflin/beats that referenced this pull request Jan 21, 2019
* fix docs build and remove title from metricset

(cherry picked from commit 68bd655)
@ruflin ruflin added v6.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 21, 2019
ruflin added a commit that referenced this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metricbeat Metricbeat module review Team:Integrations Label for the Integrations team v6.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants