Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add percona support to filebeat-module-mysql-slowlog #10210

Closed
wants to merge 3 commits into from
Closed

add percona support to filebeat-module-mysql-slowlog #10210

wants to merge 3 commits into from

Conversation

HagK
Copy link

@HagK HagK commented Jan 21, 2019

added grok pattern for percona slowlogs, includes optional InnoDB statistics
see #6665

@HagK HagK requested a review from a team as a code owner January 21, 2019 10:46
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@elasticcla
Copy link

Hi @HagK, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@jsoriano
Copy link
Member

@HagK thanks for your help here!

I have opened another PR to merge both patterns and support the example file you provided, find it here #10227, I have added you as co-author.

Let me know what you think.

@HagK
Copy link
Author

HagK commented Jan 22, 2019

@jsoriano the new PR it's fine for me. But as i understand, the gsub-pattern for Time must be extended too, because percona use the ISO 8601 timeformat with alnum characters. As i remember, i had some errors before i changed it.

@jsoriano
Copy link
Member

@HagK good point, I think this would have been needed before, but not after this change that removes also the lines starting with # Time.

Actually I am going to remove this part of the pipeline.

@jsoriano
Copy link
Member

#10227 merged, closing this.

@jsoriano jsoriano closed this Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filebeat Filebeat module review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants