[Heartbeat] Incorporate factory metadata for autodiscover #10258
Conversation
Heartbeat factories get metadata from autodiscover and other sources. This change automatically adds that data to events keeping heartbeat behavior in-line with other beats.
andrewvc
added
enhancement
in progress
|
Pinging @elastic/uptime |
andrewvc
added
review
and removed
in progress
|
@ruflin my original thinking was that the additional fields here might be considered 'breaking', but I no longer believe that. I think that was backwards. I've added the |
andrewvc
added
the
needs_backport
|
@ruflin added changelog entry (and fixed a previous one that was in the wrong spot) |
|
jenkins, test this |
| @@ -112,6 +112,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
| *Heartbeat* | |||
|
|
|||
| - Made monitors.d configuration part of the default config. {pull}9004[9004] | |||
| - Fixed rare issue where TLS connections to endpoints with x509 certificates missing either notBefore or notAfter would cause the check to fail with a stacktrace. {pull}9566[9566] | |||
There was a problem hiding this comment.
Does not seem to belong to this PR?
There was a problem hiding this comment.
Technically no, but I moved it since it was in the wrong spot. Should I make a new PR?
There was a problem hiding this comment.
Just realised now that you moved it only and was not added. All good.
andrewvc
added
v6.7.0
and removed
needs_backport
| t.client, err = t.monitor.pipelineConnector.ConnectWith(beat.ClientConfig{ | ||
| EventMetadata: t.config.EventMetadata, | ||
| Processor: t.processors, | ||
| Fields: common.MapStr{"event": common.MapStr{"dataset": "uptime"}}, | ||
| Fields: fields, |
There was a problem hiding this comment.
there is a DynamicFields here in ClientConfig, were you can pass t.monitor.factoryMetadata directly, no need for that DeepUpdate
) [Heartbeat] Incorporate factory metadata for autodiscover Heartbeat factories get metadata from autodiscover and other sources. This change automatically adds that data to events keeping heartbeat behavior in-line with other beats. (cherry picked from commit 8f4e186)
Heartbeat factories get metadata from autodiscover and other sources.
This change automatically adds that data to events keeping heartbeat behavior in-line with other beats.