Support MySQL 8, Percona and MariaDB in metricbeat #10261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
enhancement
in progress
jsoriano
force-pushed
the
metricbeat-mysql-8
branch
from
51d4a7d to
5715a7e
Compare
|
jenkins, test this again |
ruflin
reviewed
Jan 23, 2019
| @@ -3,10 +3,22 @@ | |||
| "ignore": "test github.com/elastic/beats", | |||
| "package": [ | |||
| { | |||
| "checksumSHA1": "42vkdsxNaLyPu+FktCzZ/8zsNSE=", | |||
| "path": "appengine/cloudsql", | |||
There was a problem hiding this comment.
I wonder why this entry does not have a revision but is still here?
There was a problem hiding this comment.
Umm, we have another case in the main one. This was added by govendor, maybe because it appears in an import in the google.golang.org/appengine/cloudsql package itself. 🤔
There was a problem hiding this comment.
Perhaps govendor adds an "empty" to level entry for all packages even if there is no code inside?
ruflin
approved these changes
Jan 23, 2019
jsoriano
force-pushed
the
metricbeat-mysql-8
branch
from
a3cdcbd to
87a0da7
Compare
jsoriano
changed the title
jsoriano
added
review
needs_backport
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jan 23, 2019
Test metricbeat module for MySQL with Percona and MariaDB too Update mysql driver to support default authentication method in MySQL 8. (cherry picked from commit 64c0b7f)
jsoriano
added a commit
that referenced
this pull request
Feb 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Percona, MariaDB and newer versions of MySQL in metricbeat (#10257).
Upgrade mysql driver to 1.4.1 to support default authentication method in MySQL 8.