Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the array types in fields.yml #10307

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Fixing the array types in fields.yml #10307

merged 2 commits into from
Jan 24, 2019

Conversation

ycombinator
Copy link
Contributor

Based on the conversation starting here:

#10271 (comment)

@ycombinator ycombinator added review Filebeat Filebeat Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. v7.0.0 v6.7.0 labels Jan 24, 2019
@ycombinator ycombinator requested a review from ruflin January 24, 2019 00:05
@ycombinator ycombinator requested review from a team as code owners January 24, 2019 00:05
@ycombinator ycombinator mentioned this pull request Jan 24, 2019
Merged
ruflin
ruflin reviewed Jan 24, 2019
View reviewed changes
metricbeat/module/docker/image/_meta/fields.yml
@@ -42,6 +42,6 @@
Image labels.

- name: tags
type: array
type: keyword
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exekias FYI

ruflin
ruflin reviewed Jan 24, 2019
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is also worth a changelog entry and potentially a backport. In production it did not cause any issues as all the array fields were keywords and that is our defaults.

metricbeat/module/docker/container/_meta/fields.yml
@@ -34,6 +34,6 @@
description: >
Size of the files that have been created or changed since creation.
- name: tags
type: array
type: keyword
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exekias FYI

@ycombinator
Copy link
Contributor Author

@ruflin Added CHANGELOG entries. Ready for your 👀 again. Thanks!

@ycombinator ycombinator merged commit debde55 into elastic:master Jan 24, 2019
@ycombinator ycombinator deleted the fix-type-array branch January 24, 2019 12:52
@ycombinator ycombinator mentioned this pull request Jan 24, 2019
Merged
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Jan 24, 2019
ycombinator added a commit that referenced this pull request Jan 24, 2019
@ycombinator
Fixing the array types in fields.yml (#10307) (#10317)
e864a37 
* Fixing the array types

* Adding CHANGELOG entries

(cherry picked from commit debde55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
Filebeat Filebeat Metricbeat Metricbeat review v6.7.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ycombinator @ruflin @kaiyan-sheng