Enable Docker and Kubernetes labels dedot by default #10338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
added
in progress
|
@kaiyan-sheng not sure if I covered all places? From my list this should be:
|
|
@exekias Yep I can't think of anything that you missed. But there are quite a few places in the code mentioning |
ruflin
reviewed
Jan 28, 2019
| "module": elasticsearch.ModuleName, | ||
| "metricsets": []string{metricset}, | ||
| "hosts": []string{getEnvHost() + ":" + getEnvPort()}, | ||
| "module": elasticsearch.ModuleName, |
There was a problem hiding this comment.
Looks like this change breaks CI?
kaiyan-sheng
approved these changes
Jan 29, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with 7.0 we want to make sure all container (both docker & kubernetes) labels and annotations are dedoted by default. This PR updates default settings to do so.