Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-ucfg to 0.7.0 #10363

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Update go-ucfg to 0.7.0 #10363

merged 2 commits into from
Jan 30, 2019

Conversation

urso
Copy link

@urso urso commented Jan 28, 2019

This introduces:

  • (*common.Config).Has: check for setting or namespace by path (can walk
    a configuration)
  • (*common.Config).Remove: remove a configuration.

Note: removing from dynamically parsed objects (e.g. parsed objects by
splicing in a custom string via environment variable) is not possible.

This introduces:
- (*common.Config).Has: check for setting or namespace by path (can walk
  a configuration)
- (*common.Config).Remove: remove a configuration.

Note: removing from dynamically parsed objects (e.g. parsed objects by
  splicing in a custom string via environment variable) is not possible.
@urso urso requested a review from a team as a code owner January 28, 2019 11:29
libbeat/common/config.go Show resolved Hide resolved
libbeat/common/config.go Show resolved Hide resolved
@ph
Copy link
Contributor

ph commented Jan 28, 2019

LGTM

The error look to be with metricbeat, I haven't seen this one before most likely a red herring.

======================================================================
FAIL: MySQL module outputs an event.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/go/src/github.com/elastic/beats/metricbeat/tests/system/test_mysql.py", line 37, in test_status
    self.assertItemsEqual(self.de_dot(MYSQL_FIELDS), evt.keys())
AssertionError: Element counts were not equal:
First has 1, Second has 0:  'mysql'
First has 0, Second has 1:  u'error'
-------------------- >> begin captured logging << --------------------
compose.config.config: DEBUG: Using configuration files: ./docker-compose.yml
docker.utils.config: DEBUG: Trying paths: ['/root/.docker/config.json', '/root/.dockercfg']

@urso urso merged commit a11e82a into elastic:master Jan 30, 2019
@urso urso deleted the upd/go-ucfg0.7.0 branch February 19, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants