Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Changes to text fields in logstash module #10417

Merged
merged 4 commits into from
Jan 30, 2019
Merged

[Filebeat] Changes to text fields in logstash module #10417

merged 4 commits into from
Jan 30, 2019

Conversation

ycombinator
Copy link
Contributor

This PR is an offshoot of conversations and decisions made in #10372 w.r.t text fields, but scoped to the logstash module.

@ycombinator ycombinator requested review from a team as code owners January 29, 2019 21:25
@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring

@ycombinator ycombinator mentioned this pull request Jan 29, 2019
Closed
@ycombinator ycombinator added review and removed in progress Pull request is currently in progress. labels Jan 29, 2019
ruflin
ruflin reviewed Jan 30, 2019
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog?

filebeat/module/logstash/slowlog/_meta/fields.yml Show resolved Hide resolved
@ycombinator ycombinator force-pushed the fb-ecs-text-fields-ls branch from 51179e5 to ff84d29 Compare January 30, 2019 11:08
@ycombinator
Copy link
Contributor Author

jenkins, test this

@ycombinator ycombinator force-pushed the fb-ecs-text-fields-ls branch from ff84d29 to 3c321cf Compare January 30, 2019 11:34
webmat
webmat approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I agree that each of these fields also benefits from the text indexing.

@ycombinator ycombinator merged commit ed37eea into elastic:master Jan 30, 2019
@ycombinator ycombinator deleted the fb-ecs-text-fields-ls branch December 25, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin left review comments

@webmat webmat webmat approved these changes

Assignees
No one assigned
Labels
ecs Feature:Stack Monitoring Filebeat Filebeat module review v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ycombinator @elasticmachine @webmat @ruflin