-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingest structured ES deprecation logs #10445
Merged
ycombinator
merged 4 commits into
elastic:master
from
ycombinator:fb-es-deprecation-structured
Feb 1, 2019
Merged
Ingest structured ES deprecation logs #10445
ycombinator
merged 4 commits into
elastic:master
from
ycombinator:fb-es-deprecation-structured
Feb 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
enhancement
module
review
Filebeat
Filebeat
v7.0.0
Feature:Stack Monitoring
labels
Jan 31, 2019
Pinging @elastic/stack-monitoring |
/cc @pgomulka for awareness |
ycombinator
force-pushed
the
fb-es-deprecation-structured
branch
2 times, most recently
from
January 31, 2019 03:58
bb1a0a6
to
6bc4a47
Compare
ruflin
reviewed
Jan 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase
filebeat/module/elasticsearch/deprecation/test/elasticsearch_deprecation.log-expected.json
Show resolved
Hide resolved
ycombinator
force-pushed
the
fb-es-deprecation-structured
branch
from
January 31, 2019 14:54
6bc4a47
to
557acc3
Compare
@ruflin Rebased and addressed review feedback. Ready for another pass, when you have a chance. Thanks! |
ycombinator
force-pushed
the
fb-es-deprecation-structured
branch
from
January 31, 2019 18:55
b03a4e2
to
65f970c
Compare
ruflin
approved these changes
Feb 1, 2019
ycombinator
force-pushed
the
fb-es-deprecation-structured
branch
from
February 1, 2019 12:51
65f970c
to
1c0052b
Compare
cachedout
approved these changes
Feb 1, 2019
ycombinator
force-pushed
the
fb-es-deprecation-structured
branch
2 times, most recently
from
February 1, 2019 20:28
8499ef3
to
7747334
Compare
ycombinator
force-pushed
the
fb-es-deprecation-structured
branch
from
February 1, 2019 21:36
7747334
to
cff42d3
Compare
jenkins, test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR teaches the
elasticsearch/deprecation
fileset to ingest structured Elasticsearch deprecation logs.This PR takes the same approach as #10352, in that it creates an entrypoint pipeline,
pipeline.json
, that delegates further processing of a log entry depending on what it sees as the first character of the entry:{
, it assumes the log line is structured as JSON and delegates further processing topipeline-json.json
.pipeline-plaintext.json
.