Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest structured ES deprecation logs #10445

Merged

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Jan 31, 2019

This PR teaches the elasticsearch/deprecation fileset to ingest structured Elasticsearch deprecation logs.

This PR takes the same approach as #10352, in that it creates an entrypoint pipeline, pipeline.json, that delegates further processing of a log entry depending on what it sees as the first character of the entry:

  • If the first character is {, it assumes the log line is structured as JSON and delegates further processing to pipeline-json.json.
  • Else, it assumes the log line is plaintext and delegates further processing to pipeline-plaintext.json.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring

@ycombinator ycombinator requested a review from ruflin January 31, 2019 00:34
@ycombinator
Copy link
Contributor Author

/cc @pgomulka for awareness

@ycombinator ycombinator force-pushed the fb-es-deprecation-structured branch 2 times, most recently from bb1a0a6 to 6bc4a47 Compare January 31, 2019 03:58
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase

@ycombinator ycombinator force-pushed the fb-es-deprecation-structured branch from 6bc4a47 to 557acc3 Compare January 31, 2019 14:54
@ycombinator
Copy link
Contributor Author

@ruflin Rebased and addressed review feedback. Ready for another pass, when you have a chance. Thanks!

@ycombinator ycombinator force-pushed the fb-es-deprecation-structured branch from b03a4e2 to 65f970c Compare January 31, 2019 18:55
@ycombinator ycombinator force-pushed the fb-es-deprecation-structured branch from 65f970c to 1c0052b Compare February 1, 2019 12:51
@ycombinator ycombinator force-pushed the fb-es-deprecation-structured branch 2 times, most recently from 8499ef3 to 7747334 Compare February 1, 2019 20:28

Verified

This commit was signed with the committer’s verified signature.
Crazybus Michael Russell

Verified

This commit was signed with the committer’s verified signature.
Crazybus Michael Russell

Verified

This commit was signed with the committer’s verified signature.
Crazybus Michael Russell

Verified

This commit was signed with the committer’s verified signature.
Crazybus Michael Russell
@ycombinator ycombinator force-pushed the fb-es-deprecation-structured branch from 7747334 to cff42d3 Compare February 1, 2019 21:36
@ycombinator
Copy link
Contributor Author

jenkins, test this

@ycombinator ycombinator merged commit b70fdcd into elastic:master Feb 1, 2019
@ycombinator ycombinator deleted the fb-es-deprecation-structured branch February 1, 2019 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants