Ingest structured ES slow logs #10447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
enhancement
in progress
|
Pinging @elastic/stack-monitoring |
ycombinator
force-pushed
the
fb-es-slowlog-structured
branch
from
1b9b1a3 to
35abb5f
Compare
ycombinator
commented
Jan 31, 2019
filebeat/module/elasticsearch/slowlog/test/auditlog_index_indexing_slowlog.log-expected.json
Show resolved
Hide resolved
|
Looking good so far! |
ycombinator
force-pushed
the
fb-es-slowlog-structured
branch
2 times, most recently
from
b8f6196 to
874a9cf
Compare
ycombinator
changed the title
ycombinator
added
review
and removed
in progress
ruflin
approved these changes
Feb 1, 2019
| } | ||
| }, | ||
| { | ||
| "dot_expander": { |
There was a problem hiding this comment.
Kind of odd that we need 2 steps here, but well.
There was a problem hiding this comment.
Agreed. This will help: elastic/elasticsearch#36950.
| @@ -6,7 +6,7 @@ paths: | |||
| exclude_files: [".gz$"] | |||
|
|
|||
| multiline: | |||
| pattern: '^\[?[0-9]{4}-[0-9]{2}-[0-9]{2}' | |||
| pattern: '^(\[?[0-9]{4}-[0-9]{2}-[0-9]{2}|{)' | |||
There was a problem hiding this comment.
This is kind of interesting. In the event for json it's not a multiline anymore but here we still need the multiline config 🤔
Good for now, jus thought I mention it.
ycombinator
force-pushed
the
fb-es-slowlog-structured
branch
from
874a9cf to
7d34e86
Compare
cachedout
approved these changes
Feb 1, 2019
ycombinator
force-pushed
the
fb-es-slowlog-structured
branch
from
7d34e86 to
6a6b3fa
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR teaches the
elasticsearch/slowlogfileset to ingest structured Elasticsearch search and indexing slow logs.This PR takes the same approach as #10352, in that it creates an entrypoint pipeline,
pipeline.json, that delegates further processing of a log entry depending on what it sees as the first character of the entry:{, it assumes the log line is structured as JSON and delegates further processing topipeline-json.json.pipeline-plaintext.json.