Cherry-pick #10500 to 6.x: [Auditbeat] System module: Add entity_id fields #10569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements `{entity}.entity_id` as a SHA-256 hash as proposed in elastic#10463.
Closes elastic#10463.
(cherry picked from commit c047ef7)
houndci-bot
reviewed
Feb 5, 2019
| @@ -170,6 +171,15 @@ func (user User) toMapStr() common.MapStr { | |||
| return evt | |||
| } | |||
|
|
|||
| // entityID creates an ID that uniquely identifies this user across machines. | |||
| func (u User) entityID(hostID string) string { | |||
There was a problem hiding this comment.
receiver name u should be consistent with previous receiver name user for User
| } | ||
|
|
||
| // SystemMetricSet extends the Metricbeat BaseMetricSet. | ||
| type SystemMetricSet struct { |
There was a problem hiding this comment.
type name will be used as system.SystemMetricSet by other packages, and that stutters; consider calling this MetricSet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #10500 to 6.x branch. Original message:
Implements
{entity}.entity_idas a SHA-256 hash as proposed in #10463.The new fields and what goes in the hash:
system.audit.package.entity_idhost.id + name + versionprocess.entity_idhost.id + PID + StartTimesocket.entity_idhost.id + inode + LocalIP + RemoteIP + LocalPort + RemotePortuser.entity_idhost.id + UID + usernameNote:
socketis a net new top-level object, I just didn't see where else to put it. Open to suggestions.host.idis retrieved when the system module is created and stored so the individual datasets don't have to re-fetch it. It's exposed to all through a newSystemMetricSet.Closes #10463.