Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration knob for auto-discover default.disable #10818

Closed
wants to merge 9 commits into from
Closed

Add configuration knob for auto-discover default.disable #10818

wants to merge 9 commits into from

Conversation

alakahakai
Copy link

@alakahakai alakahakai commented Feb 18, 2019

Address {issue}10811[10811]

…ver hints to control whether log harvesting is enabled for the pod/container. {issue}10811[10811] {issue}10812[10812]
@alakahakai alakahakai added enhancement in progress Pull request is currently in progress. module Filebeat Filebeat labels Feb 18, 2019
@alakahakai alakahakai requested review from a team as code owners February 18, 2019 22:28
@alakahakai alakahakai added review and removed in progress Pull request is currently in progress. labels Feb 19, 2019
@alakahakai alakahakai self-assigned this Feb 19, 2019
@alakahakai
Copy link
Author

jenkins, test this

@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

@alakahakai alakahakai requested review from tsg and andrewkroh February 19, 2019 16:01
@alakahakai
Copy link
Author

jenkins, test this

@jsoriano
Copy link
Member

@alakahakai thanks for adressing these issues!

Could you please split this in two PRs, one for the module and another one for the added setting?

@alakahakai
Copy link
Author

@jsoriano OK, will do.

@alakahakai alakahakai changed the title Add Filebeat kubernetes module. Add configuration knob for auto-discover default.disable Add configuration knob for auto-discover default.disable Feb 20, 2019
@alakahakai alakahakai removed the module label Feb 20, 2019
@alakahakai alakahakai removed their assignment Feb 22, 2019
@alakahakai
Copy link
Author

I am closing this to do a clean PR - {pull}10911[10911]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants