-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration knob for auto-discover default.disable #10818
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver hints to control whether log harvesting is enabled for the pod/container. {issue}10811[10811] {issue}10812[10812]
alakahakai
added
enhancement
in progress
Pull request is currently in progress.
module
Filebeat
Filebeat
labels
Feb 18, 2019
alakahakai
added
review
and removed
in progress
Pull request is currently in progress.
labels
Feb 19, 2019
jenkins, test this |
Pinging @elastic/secops |
jenkins, test this |
@alakahakai thanks for adressing these issues! Could you please split this in two PRs, one for the module and another one for the added setting? |
@jsoriano OK, will do. |
alakahakai
changed the title
Add Filebeat kubernetes module. Add configuration knob for auto-discover default.disable
Add configuration knob for auto-discover default.disable
Feb 20, 2019
…o-discover default.disable
I am closing this to do a clean PR - {pull}10911[10911] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address {issue}10811[10811]