Stabilize test_input_pipeline_config #10822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
approved these changes
Feb 27, 2019
|
I put this PR on hold to come up with a solution for running these tests in parallel. As I am deleting the pipelines for a time being, it's possible if other tests require those pipelines, they will fail |
|
@kvch what is the state of this PR? Can we merge it? |
|
We haven't seen test_input_pipeline_config show up in the build stats for a while so this might be stable now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_input_pipeline_confighas been unstable due to too many dynamic scripts executions when uploading the test pipeline. As this pipeline is super primitive, it is highly unlikely that it causes the issue. However, when a new pipeline is uploaded all of those are reloaded on all nodes, so it is possible that an existing pipeline creates the problem. To avoid this, all existing pipelines are deleted while the test is being run. When the test terminates, pipelines are uploaded again not to mess up the existing environment.This PR only stabilises the test. But the issue still needs an investigation to see which pipeline leads to too many script executions. To make debugging a bit easier, I have added a debug print to see which pipeline fails when the problem resurfaces.
Closes #9587
Closes #9600