-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement basic testing for the kafka output module #10834
Implement basic testing for the kafka output module #10834
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@Popsiclestick this is looking good, thanks! Before merging this change you will have to sign the CLA. To obtain the TLS configuration you may try to do the reverse operation of |
jenkins, test this |
I signed it. Strange though, I had already signed the agreement last week. Not sure, but hopefully it works now. |
@Popsiclestick sorry, it seems that there was some kind of problem with CLA checker, could you try to sign it again? |
Signed again :) |
@Popsiclestick right, it seems to be working now 🎉 Do you want to give another try to TLS config? If not I think this is ready to go, and TLS can be added later. |
Wooh! @jsoriano I think we should merge this in for now. If I get some more time in the future, I can look at trying to get TLS added later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@Popsiclestick oh sorry, I almost forgot it! I think this change should have an entry in |
@jsoriano Everything look good now? 👍 |
jenkins, test this |
@Popsiclestick looks good, thanks! I'll merge it when everything is green 🙂 |
This PR is for #10652
I've implemented the same TCP connection test found in the elasticsearch output test. This is a basic test.
Example output below
Note:
The test will function whether or not the kafka server requires TLS. I did look to implement the
transport.TestTLSDialer
as well. But the TLS config objects which are passed don't look to be standardized between outputs. Kafka morphs the original object to integrate with sarama. The kafka client only has access tosarama.Config
which doesn't contain the original object to performtlscommon.LoadTLSConfig
. Though I am likely missing something.I am happy to implement any recommendations.