Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log EOFs found on Kubernetes watcher at debug level #10988

Merged

Conversation

jsoriano
Copy link
Member

EOFs received when watching Kubernetes events can be recovered by
reconnecting, and they don't need to be harmful. So log them at the
debug level.
If after the EOF there are still problems, errors will still be logged at
the error level when reconnecting.

EOFs received when watching Kubernetes events can be recovered by
reconnecting, and they don't need to be harmful. So log them at the
debug level.
@jsoriano jsoriano added review libbeat needs_backport PR is waiting to be backported to other branches. v7.0.0 Team:Integrations Label for the Integrations team labels Feb 28, 2019
@jsoriano jsoriano self-assigned this Feb 28, 2019
@jsoriano jsoriano requested a review from a team as a code owner February 28, 2019 14:52
case io.EOF:
logp.Debug("kubernetes", "EOF while watching API")
case io.ErrUnexpectedEOF:
logp.Warn("kubernetes: Unexpected EOF while watching API")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically we tried not to use Warn but Error or Info to make it clear if action is needed or not. I'm tempted to think this should be logged on Info level as no action is needed normally?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, changed to Info 👍

@ruflin
Copy link
Contributor

ruflin commented Mar 5, 2019

jenkins, test this

@ruflin
Copy link
Contributor

ruflin commented Mar 5, 2019

I have seen the elasticsearch tests failing now on 2-3 PR's. I wonder if there was a change in ES that is causing it. Will investigate if it happens again.

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Was wondering if this is worth a changelog entry as it has a small user impact.

@jsoriano
Copy link
Member Author

jsoriano commented Mar 5, 2019

@ruflin changelog entry added

@jsoriano jsoriano merged commit 50ab684 into elastic:master Mar 5, 2019
@jsoriano jsoriano deleted the kubernetes-watcher-reconnect-errors branch March 5, 2019 12:33
@ghost ghost added [zube]: Done and removed [zube]: In Review labels Mar 5, 2019
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Mar 5, 2019
jsoriano added a commit to jsoriano/beats that referenced this pull request Mar 5, 2019
EOFs received when watching Kubernetes events can be recovered by
reconnecting, and they don't need to be harmful. So log them at the
debug level.

(cherry picked from commit 50ab684)
jsoriano added a commit that referenced this pull request Mar 6, 2019
EOFs received when watching Kubernetes events can be recovered by
reconnecting, and they don't need to be harmful. So log them at the
debug level.

(cherry picked from commit 50ab684)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants