-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log EOFs found on Kubernetes watcher at debug level #10988
Log EOFs found on Kubernetes watcher at debug level #10988
Conversation
EOFs received when watching Kubernetes events can be recovered by reconnecting, and they don't need to be harmful. So log them at the debug level.
libbeat/common/kubernetes/watcher.go
Outdated
case io.EOF: | ||
logp.Debug("kubernetes", "EOF while watching API") | ||
case io.ErrUnexpectedEOF: | ||
logp.Warn("kubernetes: Unexpected EOF while watching API") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Historically we tried not to use Warn
but Error or Info to make it clear if action is needed or not. I'm tempted to think this should be logged on Info
level as no action is needed normally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, changed to Info
👍
jenkins, test this |
I have seen the elasticsearch tests failing now on 2-3 PR's. I wonder if there was a change in ES that is causing it. Will investigate if it happens again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Was wondering if this is worth a changelog entry as it has a small user impact.
@ruflin changelog entry added |
EOFs received when watching Kubernetes events can be recovered by reconnecting, and they don't need to be harmful. So log them at the debug level. (cherry picked from commit 50ab684)
EOFs received when watching Kubernetes events can be recovered by
reconnecting, and they don't need to be harmful. So log them at the
debug level.
If after the EOF there are still problems, errors will still be logged at
the error level when reconnecting.